From: Jani Nikula <jani.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
Date: Wed, 07 Apr 2021 15:46:37 +0300 [thread overview]
Message-ID: <87h7kijm8i.fsf@intel.com> (raw)
In-Reply-To: <20210407122337.77493-1-andriy.shevchenko@linux.intel.com>
On Wed, 07 Apr 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
That's hardly drm/i915 specific!
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
But who's going to pick it up and, hopefully, change the subject prefix
to ascii85 or something?
> ---
> include/linux/ascii85.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
> #ifndef _ASCII85_H_
> #define _ASCII85_H_
>
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
>
> #define ASCII85_BUFSZ 6
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-04-07 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 12:23 [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h Andy Shevchenko
2021-04-07 12:46 ` Jani Nikula [this message]
2021-04-07 13:40 ` Andy Shevchenko
2021-04-07 13:41 ` Andy Shevchenko
2021-05-17 12:19 ` Andy Shevchenko
2021-05-17 12:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7kijm8i.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox