From: ebiederm@xmission.com (Eric W. Biederman)
To: linmiaohe <linmiaohe@huawei.com>
Cc: "christian.brauner\@ubuntu.com" <christian.brauner@ubuntu.com>,
"akpm\@linux-foundation.org" <akpm@linux-foundation.org>,
"peterz\@infradead.org" <peterz@infradead.org>,
"mingo\@kernel.org" <mingo@kernel.org>,
"christian\@kellner.me" <christian@kellner.me>,
"surenb\@google.com" <surenb@google.com>,
"areber\@redhat.com" <areber@redhat.com>,
"shakeelb\@google.com" <shakeelb@google.com>,
"cyphar\@cyphar.com" <cyphar@cyphar.com>,
"tglx\@linutronix.de" <tglx@linutronix.de>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap()
Date: Mon, 14 Sep 2020 07:03:03 -0500 [thread overview]
Message-ID: <87h7s0va4o.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <23352bc3a9914e79a0aa29bc63f830bd@huawei.com> (linmiaohe's message of "Mon, 14 Sep 2020 01:38:24 +0000")
linmiaohe <linmiaohe@huawei.com> writes:
> Eric W. Biederman <ebiederm@xmission.com> wrote:
>> Miaohe Lin <linmiaohe@huawei.com> writes:
>>
>>> Use helper function mapping_allow_writable() to atomic_inc
>>> i_mmap_writable.
>>
>>Why?
>>
>
> Because I think it's better to use the wrapper function instead of the
> open hard code.
My point is there is no context in this commit message.
What makes it better to use the wrapper function?
What makes the wrapper function the appropriate function to use?
Why just this location?
Why wasn't this change made when the wrapper function was introduced?
I could probably read through the code and figure these things out
but the description of the change should really include these things.
Eric
next prev parent reply other threads:[~2020-09-14 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 1:38 [PATCH] fork: Use helper function mapping_allow_writable() in dup_mmap() linmiaohe
2020-09-14 12:03 ` Eric W. Biederman [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-16 1:39 linmiaohe
2020-09-15 9:25 linmiaohe
2020-09-13 9:24 Miaohe Lin
2020-09-13 16:18 ` Eric W. Biederman
2020-09-15 15:47 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7s0va4o.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=areber@redhat.com \
--cc=christian.brauner@ubuntu.com \
--cc=christian@kellner.me \
--cc=cyphar@cyphar.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox