From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <maz@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux@armlinux.org.uk, luto@kernel.org,
m.szyprowski@samsung.com, Mark.Rutland@arm.com
Subject: Re: [PATCH v2 0/3] Fix arm_arch_timer clockmode when vDSO disabled
Date: Mon, 24 Feb 2020 10:12:11 +0100 [thread overview]
Message-ID: <87h7zg4adw.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200222104005.6fc4019d@why>
Marc Zyngier <maz@kernel.org> writes:
> On Fri, 21 Feb 2020 18:18:46 +0000
> Vincenzo Frascino <vincenzo.frascino@arm.com> wrote:
>>
>> This patch series addresses the issue defining a default arch clockmode
>> for arm and arm64 and using it to initialize the arm_arch_timer.
>
> arm only. arm64 is just fine.
Right. ARM64 unconditionaly enables VDSO
>
> This doesn't apply to -rc2, and is rather against next.
More precise it's against tip timers/core which has the VDSO changes
which caused this fallout.
>> Vincenzo Frascino (3):
>> arm: clocksource: Add VDSO default clockmode
>> arm64: clocksource: Add VDSO default clockmode
>> clocksource: Fix arm_arch_timer clockmode when vDSO disabled
>
> Please squash the three patches into a single one. There is zero point
> in having 3 patches for something that small.
I really don't see why we need all this redefine foo. What's wrong with
the obvious?
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -69,7 +69,12 @@ static enum arch_timer_ppi_nr arch_timer
static bool arch_timer_c3stop;
static bool arch_timer_mem_use_virtual;
static bool arch_counter_suspend_stop;
+
+#ifdef CONFIG_GENERIC_GETTIMEOFDAY
static enum vdso_clock_mode vdso_default = VDSO_CLOCKMODE_ARCHTIMER;
+#else
+static enum vdso_clock_mode vdso_default = VDSO_CLOCKMODE_NONE;
+#endif
static cpumask_t evtstrm_available = CPU_MASK_NONE;
static bool evtstrm_enable = IS_ENABLED(CONFIG_ARM_ARCH_TIMER_EVTSTREAM);
next prev parent reply other threads:[~2020-02-24 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 18:18 [PATCH v2 0/3] Fix arm_arch_timer clockmode when vDSO disabled Vincenzo Frascino
2020-02-21 18:18 ` [PATCH v2 1/3] arm: clocksource: Add VDSO default clockmode Vincenzo Frascino
2020-02-21 18:18 ` [PATCH v2 2/3] arm64: " Vincenzo Frascino
2020-02-21 18:18 ` [PATCH v2 3/3] clocksource: Fix arm_arch_timer clockmode when vDSO disabled Vincenzo Frascino
2020-02-22 10:40 ` [PATCH v2 0/3] " Marc Zyngier
2020-02-24 9:12 ` Thomas Gleixner [this message]
2020-02-24 10:12 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7zg4adw.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Mark.Rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox