From: Nathan Lynch <nathanl@linux.ibm.com>
To: Scott Cheloha <cheloha@linux.vnet.ibm.com>
Cc: ricklind@linux.vnet.ibm.com,
Scott Cheloha <cheloha@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v3] drivers/base/memory.c: cache blocks in radix tree to accelerate lookup
Date: Thu, 19 Dec 2019 12:09:03 -0600 [thread overview]
Message-ID: <87h81wjigw.fsf@linux.ibm.com> (raw)
In-Reply-To: <20191217193238.3098-1-cheloha@linux.vnet.ibm.com>
Scott Cheloha <cheloha@linux.vnet.ibm.com> writes:
> Searching for a particular memory block by id is slow because each block
> device is kept in an unsorted linked list on the subsystem bus.
>
> Lookup is much faster if we cache the blocks in a radix tree. Memory
> subsystem initialization and hotplug/hotunplug is at least a little faster
> for any machine with more than ~100 blocks, and the speedup grows with
> the block count.
>
> Signed-off-by: Scott Cheloha <cheloha@linux.vnet.ibm.com>
> Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Nathan Lynch <nathanl@linux.ibm.com>
Thanks Scott.
next prev parent reply other threads:[~2019-12-19 18:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 19:25 [PATCH] memory subsystem: cache memory blocks in radix tree to accelerate lookup Scott Cheloha
2019-11-21 9:34 ` David Hildenbrand
2019-11-21 9:35 ` David Hildenbrand
2019-11-21 19:59 ` [PATCH v2] drivers/base/memory.c: cache " Scott Cheloha
2019-11-25 6:36 ` kbuild test robot
2019-12-17 19:32 ` [PATCH v3] " Scott Cheloha
2019-12-18 9:00 ` David Hildenbrand
2019-12-19 17:33 ` Scott Cheloha
2019-12-20 10:50 ` David Hildenbrand
2019-12-19 18:09 ` Nathan Lynch [this message]
2020-01-07 21:48 ` Michal Hocko
2020-01-08 13:36 ` David Hildenbrand
2020-01-08 14:21 ` Michal Hocko
2020-01-08 15:23 ` David Hildenbrand
2020-01-09 8:49 ` Michal Hocko
2020-01-09 8:56 ` Greg Kroah-Hartman
2020-01-09 9:19 ` Michal Hocko
2020-01-09 9:24 ` David Hildenbrand
2020-01-09 9:31 ` David Hildenbrand
2020-01-09 9:41 ` Greg Kroah-Hartman
2020-01-09 9:33 ` Greg Kroah-Hartman
2020-01-09 9:50 ` Michal Hocko
2020-01-09 9:48 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h81wjigw.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=cheloha@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ricklind@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox