From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F41CC04AB4 for ; Fri, 17 May 2019 21:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65C942087E for ; Fri, 17 May 2019 21:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729329AbfEQV0V (ORCPT ); Fri, 17 May 2019 17:26:21 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48437 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727568AbfEQV0V (ORCPT ); Fri, 17 May 2019 17:26:21 -0400 X-Originating-IP: 87.231.134.186 Received: from localhost (87-231-134-186.rev.numericable.fr [87.231.134.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 6FFC5FF808; Fri, 17 May 2019 21:26:11 +0000 (UTC) From: Gregory CLEMENT To: Heinrich Schuchardt , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Russell King Cc: Rob Herring , Mark Rutland , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH 1/1] arm64: dts: marvell: mcbin: enlarge PCI memory window In-Reply-To: References: <20190517161123.9293-1-xypron.glpk@gmx.de> <87k1eozvxb.fsf@FE-laptop> Date: Fri, 17 May 2019 23:26:10 +0200 Message-ID: <87h89szsb1.fsf@FE-laptop> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 5/17/19 10:08 PM, Gregory CLEMENT wrote: >> Hi Heinrich Schuchardt, >> >>> Running a graphics adapter on the MACCHIATObin fails due to an >>> insufficently sized memory window. >> I think "insufficient" is enough or I miss something. > > Thanks for reviewing. Do I have to resend with corrected wording? Actually I was said that using an adverbe was the thing to do, so I've just fix the typo by adding the missing "i". you don't have to resend it. > >> >>> >>> Enlarge the memory window for the PCIe slot to 512 MiB. >>> >>> With the patch I am able to use a GT710 graphics adapter with 1 GB onboard >>> memory. >>> >>> These are the mapped memory areas that the graphics adapter is actually >>> using: >>> >>> Region 0: Memory at cc000000 (32-bit, non-prefetchable) [size=16M] >>> Region 1: Memory at c0000000 (64-bit, prefetchable) [size=128M] >>> Region 3: Memory at c8000000 (64-bit, prefetchable) [size=32M] >>> Region 5: I/O ports at 1000 [size=128] >>> Expansion ROM at ca000000 [disabled] [size=512K] >> >>>>From my point of view this patch is correct, I don't think it is a >> problem to map more memory. So I applied on it mvebu/dt64. >> > > To which repository are your referring? I thought it was documented in the MAINTAINER file but I was wrong, so I will fix it. I referred to git://git.infradead.org/linux-mvebu.git this branch will be merged in our for-next branch when 5.2-rc1 will be released, so it will be part of linux-next. Gregory > > Best regards > > Heinrich > >> But I add also Thomas in CC who know better the PCIe support on mvebu/ >> >> Thanks, >> >> Gregory >> >> >>> >>> Signed-off-by: Heinrich Schuchardt >>> --- >>> arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi >>> index 329f8ceeebea..205071b45a32 100644 >>> --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi >>> +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dtsi >>> @@ -184,6 +184,8 @@ >>> num-lanes = <4>; >>> num-viewport = <8>; >>> reset-gpios = <&cp0_gpio2 20 GPIO_ACTIVE_LOW>; >>> + ranges = <0x81000000 0x0 0xf9010000 0x0 0xf9010000 0x0 0x10000 >>> + 0x82000000 0x0 0xc0000000 0x0 0xc0000000 0x0 0x20000000>; >>> status = "okay"; >>> }; >>> >>> -- >>> 2.20.1 >>> >> > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com