From: Kalle Valo <kvalo@codeaurora.org>
To: kbuild test robot <lkp@intel.com>
Cc: Niklas Cassel <niklas.cassel@linaro.org>,
kbuild-all@01.org, "David S. Miller" <davem@davemloft.net>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST
Date: Wed, 13 Jun 2018 12:56:02 +0300 [thread overview]
Message-ID: <87h8m7au31.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <201806122228.8vAQXcD6%fengguang.wu@intel.com> (kbuild test robot's message of "Tue, 12 Jun 2018 22:50:37 +0800")
kbuild test robot <lkp@intel.com> writes:
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on ath6kl/ath-next]
> [also build test WARNING on next-20180612]
> [cannot apply to v4.17]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Niklas-Cassel/ath10k-do-not-mix-spaces-and-tabs-in-Kconfig/20180612-194241
> base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/wireless/ath/ath10k/snoc.c:823:5: sparse: symbol
>>> 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be
>>> static?
>>> drivers/net/wireless/ath/ath10k/snoc.c:871:6: sparse: symbol
>>> 'ath10k_snoc_init_napi' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.
There's already a patch pending to fix these:
ath10k: make some functions static
https://patchwork.kernel.org/patch/10440159/
--
Kalle Valo
next prev parent reply other threads:[~2018-06-13 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 11:39 [PATCH 1/2] ath10k: do not mix spaces and tabs in Kconfig Niklas Cassel
2018-06-12 11:39 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST Niklas Cassel
[not found] ` <7058492257914633b55fcd423e4c0b59@aphydexm01b.ap.qualcomm.com>
2018-06-12 12:32 ` FW: " Govind Singh
2018-06-12 12:44 ` Niklas Cassel
2018-06-13 8:47 ` Kalle Valo
2018-06-13 13:28 ` Niklas Cassel
2018-06-14 14:09 ` Kalle Valo
2018-06-14 18:42 ` Niklas Cassel
2018-06-12 14:50 ` [RFC PATCH] ath10k: ath10k_snoc_get_ce_id_from_irq() can be static kbuild test robot
2018-06-13 9:57 ` Kalle Valo
2018-06-12 14:50 ` [PATCH 2/2] ath10k: allow ATH10K_SNOC with COMPILE_TEST kbuild test robot
2018-06-13 9:56 ` Kalle Valo [this message]
2018-07-04 9:59 ` [2/2] " Kalle Valo
[not found] ` <20180704095913.772C9606AC@smtp.codeaurora.org>
2018-07-04 11:20 ` Niklas Cassel
2018-09-03 16:59 ` [PATCH 2/2] " Kalle Valo
2018-06-14 15:18 ` [1/2] ath10k: do not mix spaces and tabs in Kconfig Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8m7au31.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox