From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org
Subject: Re: [PATCH 02/16] hyper-v: trace vmbus_on_message()
Date: Wed, 04 Oct 2017 16:09:47 +0200 [thread overview]
Message-ID: <87h8vfj978.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20171003095447.1e99069c@xeon-e3> (Stephen Hemminger's message of "Tue, 3 Oct 2017 09:54:47 -0700")
Stephen Hemminger <stephen@networkplumber.org> writes:
> On Thu, 21 Sep 2017 10:17:18 +0200
> Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
>> Steven Rostedt <rostedt@goodmis.org> writes:
>>
>> > On Wed, 20 Sep 2017 19:21:53 +0200
>> > Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>> >
>> >> diff --git a/drivers/hv/hv_trace.h b/drivers/hv/hv_trace.h
>> >> index 9a29ef55477d..72911dfc9682 100644
>> >> --- a/drivers/hv/hv_trace.h
>> >> +++ b/drivers/hv/hv_trace.h
>> >> @@ -14,6 +14,14 @@ TRACE_EVENT(vmbus_on_msg_dpc,
>> >> TP_printk("message %u received", __entry->msgtype)
>> >> );
>> >>
>> >> +TRACE_EVENT(vmbus_on_message,
>> >> + TP_PROTO(const struct vmbus_channel_message_header *hdr),
>> >> + TP_ARGS(hdr),
>> >> + TP_STRUCT__entry(__field(unsigned int, msgtype)),
>> >> + TP_fast_assign(__entry->msgtype = hdr->msgtype),
>> >> + TP_printk("processing message %u", __entry->msgtype)
>> >> + );
>> >
>> > Whenever you have two trace events with everything the same but the
>> > TP_printk(), you can save a little space by using DEFINE_EVENT_PRINT()
>> >
>> > DECLARE_EVENT_CLASS(vmbus_hdr_msg,
>> > TP_PROTO(const struct vmbus_channel_message_header *hdr),
>> > TP_ARGS(hdr),
>> > TP_STRUCT__entry(__field(unsigned int, msgtype),
>> > TP_fast_assign(__entry->msg = hdr->msgtype;),
>> > TP_printk("msgtype=%d", __entry->msgtype)
>> > );
>> >
>> > DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_msg_dpc,
>> > TP_PROTO(const struct vmbus_channel_message_header *hdr),
>> > TP_ARGS(hdr),
>> > TP_printk("message %u received", __entry->msgtype));
>> >
>> > DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_message,
>> > TP_PROTO(const struct vmbus_channel_message_header *hdr),
>> > TP_ARGS(hdr),
>> > TP_printk("processing message %u", __entry->msgtype));
>> >
>> > This will use the same functions required to save and record the
>> > message but will use a different function to output it to the trace.
>>
>> Oh, thanks! This seems to be useful for
>> vmbus_on_msg_dpc/vmbus_on_message only as all the rest needs to parse
>> different structures. Will use it in v2.
>>
>
> I just used this patch. Since function name is already in the trace message
> no need to have different print's for each one.
>
Sure, will incorporate this into v3.
> From ff85967810c216eb01d181789af4f56bd00dc9b9 Mon Sep 17 00:00:00 2001
> From: Stephen Hemminger <sthemmin@microsoft.com>
> Date: Tue, 3 Oct 2017 09:24:11 -0700
> Subject: [PATCH 3/4] hyperv: fix warnings in trace print
>
> This gets rid of the build warnings from unused printf format.
> And uses common class for print.
> ---
> drivers/hv/hv_trace.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/hv/hv_trace.h b/drivers/hv/hv_trace.h
> index be7762955650..4755c4640e39 100644
> --- a/drivers/hv/hv_trace.h
> +++ b/drivers/hv/hv_trace.h
> @@ -11,18 +11,18 @@ DECLARE_EVENT_CLASS(vmbus_hdr_msg,
> TP_ARGS(hdr),
> TP_STRUCT__entry(__field(unsigned int, msgtype)),
> TP_fast_assign(__entry->msgtype = hdr->msgtype;),
> - TP_printk("msgtype=%d", __entry->msgtype)
> + TP_printk("msgtype=%u", __entry->msgtype)
> );
>
> -DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_msg_dpc,
> +DEFINE_EVENT(vmbus_hdr_msg, vmbus_on_msg_dpc,
> TP_PROTO(const struct vmbus_channel_message_header *hdr),
> - TP_ARGS(hdr),
> - TP_printk("message %u received", __entry->msgtype));
> + TP_ARGS(hdr)
> +);
>
> -DEFINE_EVENT_PRINT(vmbus_hdr_msg, vmbus_on_message,
> +DEFINE_EVENT(vmbus_hdr_msg, vmbus_on_message,
> TP_PROTO(const struct vmbus_channel_message_header *hdr),
> - TP_ARGS(hdr),
> - TP_printk("processing message %u", __entry->msgtype));
> + TP_ARGS(hdr)
> +);
>
> TRACE_EVENT(vmbus_onoffer,
> TP_PROTO(const struct vmbus_channel_offer_channel *offer),
--
Vitaly
next prev parent reply other threads:[~2017-10-04 14:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 17:21 [PATCH 00/16] Hyper-V: add tracing to VMBus module and trace all messages Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 01/16] hyper-v: trace vmbus_on_msg_dpc() Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 02/16] hyper-v: trace vmbus_on_message() Vitaly Kuznetsov
2017-09-20 17:55 ` Steven Rostedt
2017-09-21 8:17 ` Vitaly Kuznetsov
2017-10-03 16:54 ` Stephen Hemminger
2017-10-04 14:09 ` Vitaly Kuznetsov [this message]
2017-09-20 17:21 ` [PATCH 03/16] hyper-v: trace vmbus_onoffer() Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 04/16] hyper-v: trace vmbus_onoffer_rescind() Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 05/16] hyper-v: trace vmbus_onopen_result() Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 06/16] hyper-v: trace vmbus_ongpadl_created() Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 07/16] hyper-v: trace vmbus_ongpadl_torndown() Vitaly Kuznetsov
2017-09-20 17:21 ` [PATCH 08/16] hyper-v: trace vmbus_onversion_response() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 09/16] hyper-v: trace vmbus_request_offers() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 10/16] hyper-v: trace vmbus_open() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 11/16] hyper-v: trace vmbus_close_internal() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 12/16] hyper-v: trace vmbus_establish_gpadl() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 13/16] hyper-v: trace vmbus_teardown_gpadl() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 14/16] hyper-v: trace vmbus_negotiate_version() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 15/16] hyper-v: trace vmbus_release_relid() Vitaly Kuznetsov
2017-09-20 17:22 ` [PATCH 16/16] hyper-v: trace vmbus_send_tl_connect_request() Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8vfj978.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox