From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdJBNqo (ORCPT ); Mon, 2 Oct 2017 09:46:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbdJBNql (ORCPT ); Mon, 2 Oct 2017 09:46:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1CB456071D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: =?utf-8?B?SsOpcsOpbXk=?= Lefaure Cc: Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Jeff Kirsher , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Larry Finger , Chaoming Li , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: Re: [PATCH 05/18] net: use ARRAY_SIZE References: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> <20171001193101.8898-6-jeremy.lefaure@lse.epita.fr> Date: Mon, 02 Oct 2017 16:46:29 +0300 In-Reply-To: <20171001193101.8898-6-jeremy.lefaure@lse.epita.fr> (=?utf-8?B?IkrDqXLDqW15?= Lefaure"'s message of "Sun, 1 Oct 2017 15:30:43 -0400") Message-ID: <87h8vh64sq.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v92DkmK6018824 Jérémy Lefaure writes: > Using the ARRAY_SIZE macro improves the readability of the code. Also, > it is not always useful to use a variable to store this constant > calculated at compile time. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure > --- > drivers/net/ethernet/emulex/benet/be_cmds.c | 4 +- > drivers/net/ethernet/intel/i40e/i40e_adminq.h | 3 +- > drivers/net/ethernet/intel/i40evf/i40e_adminq.h | 3 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 3 +- > drivers/net/ethernet/intel/ixgbevf/vf.c | 17 +- > drivers/net/usb/kalmia.c | 9 +- > .../broadcom/brcm80211/brcmsmac/phy/phytbl_n.c | 473 ++++++--------------- > .../net/wireless/realtek/rtlwifi/rtl8723be/hw.c | 9 +- > .../net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 12 +- > .../net/wireless/realtek/rtlwifi/rtl8723be/table.c | 14 +- > .../net/wireless/realtek/rtlwifi/rtl8821ae/table.c | 34 +- > include/net/bond_3ad.h | 3 +- > net/ipv6/seg6_local.c | 6 +- > 13 files changed, 177 insertions(+), 413 deletions(-) We have a tree for wireless so usually it's better to submit wireless changes on their own but here I assume Dave will apply this to his tree. If not, please resubmit the wireless part in a separate patch. -- Kalle Valo