From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757385AbcHCCiT (ORCPT ); Tue, 2 Aug 2016 22:38:19 -0400 Received: from ozlabs.org ([103.22.144.67]:34255 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756699AbcHCCiH (ORCPT ); Tue, 2 Aug 2016 22:38:07 -0400 From: Rusty Russell To: Baole Ni , rpurdie@rpsys.net, j.anaszewski@samsung.com, hal.rosenstock@gmail.com, dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de Cc: lguest@lists.ozlabs.org, linux-kernel@vger.kernel.org, mingo@kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: Re: [PATCH 0309/1285] Replace numeric parameter like 0444 with macro In-Reply-To: <20160802105854.2073-1-baolex.ni@intel.com> References: <20160802105854.2073-1-baolex.ni@intel.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Wed, 03 Aug 2016 12:07:19 +0930 Message-ID: <87h9b2y3vk.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. I find the numbers far, far more readable. Cheers, Rusty. > /* Allow Guests to use a non-128 (ie. non-Linux) syscall trap. */ > static unsigned int syscall_vector = IA32_SYSCALL_VECTOR; > -module_param(syscall_vector, uint, 0444); > +module_param(syscall_vector, uint, S_IRUSR | S_IRGRP | S_IROTH); > > /* The address of the interrupt handler is split into two bits: */ > static unsigned long idt_address(u32 lo, u32 hi) > -- > 2.9.2