From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756904AbcHBOl6 (ORCPT ); Tue, 2 Aug 2016 10:41:58 -0400 Received: from mga14.intel.com ([192.55.52.115]:30637 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934985AbcHBOd7 (ORCPT ); Tue, 2 Aug 2016 10:33:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="asc'?scan'208";a="1018266952" From: Felipe Balbi To: Baole Ni , gregkh@linuxfoundation.org, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, mina86@mina86.com, deepa.kernel@gmail.com, mathias.nyman@linux.intel.com, stern@rowland.harvard.edu, oneukum@suse.com Subject: Re: [PATCH 0987/1285] Replace numeric parameter like 0444 with macro In-Reply-To: <20160802120536.15873-1-baolex.ni@intel.com> References: <20160802120536.15873-1-baolex.ni@intel.com> User-Agent: Notmuch/0.22+58~g3a45d29 (https://notmuchmail.org) Emacs/25.0.95.2 (x86_64-pc-linux-gnu) Date: Tue, 02 Aug 2016 16:53:34 +0300 Message-ID: <87h9b3qntt.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Baole Ni writes: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permiss= ion. > As we know, these numeric value for access permission have had the corres= ponding macro, > and that using macro can improve the robustness and readability of the co= de, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/usb/phy/phy-twl6030-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6= 030-usb.c > index a72e8d6..4ed75c6 100644 > --- a/drivers/usb/phy/phy-twl6030-usb.c > +++ b/drivers/usb/phy/phy-twl6030-usb.c > @@ -208,7 +208,7 @@ static ssize_t twl6030_usb_vbus_show(struct device *d= ev, >=20=20 > return ret; > } > -static DEVICE_ATTR(vbus, 0444, twl6030_usb_vbus_show, NULL); > +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, twl6030_usb_vbus_s= how, NULL); line too long =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXoKXeAAoJEIaOsuA1yqRElF0P/RzHr/oCZhG5E0RRQ+83zuTQ 8XhAcbPvX3H88y2+hkw7Y95pX/1v40oRcRruCAfOS802hYkEC9SVF9fVYAkhShKZ tUD4b0k0Ir8qLvCSmeGZYKQQyjQZyWPCKBeuLTwIAb2/VyGHsPg6LvbvF3ZRs43n SLpqIJgx5EJvQYZ5zuEKtN9SuQbfaIESlOxjPaqua7rFvRt+AFDbZgCY/cESuZBY R0NRMZUbdhJmgLnbzaExAXo8sDkRsCop3wnxPZgnsWwz+qu1JRlhkKqbByYGAHI4 Ufq5O+l/nAVIb5AajA/yI8BHhbdU21rRwl9PQ5YlUE6a45FnbMmCEaBJNZgle/A0 rTWkVE3S3h7JW2mlww4NDNqM+6WQYElgAPt2/9FuGx5v5uvEIk3FadJKVGLoLWEM PMQatEyuJoU2y6nDp9oBi53QQ7jiJuUku66956ln2Eg+AXzrMLxZxkpj30xsK7DK uCtN/4ZQ5MJN1/mPBYs/KwoMiewfHyFI/CV8w17gPqnyGJFwJGqpd4uGNHoh3O7K 46t1PAqfOunIbNyCDGgLEigx3X2bXqTFqehtJ+24J7k7ybaaNuUYrLG2glPi75hr 0osSljZqVVlX/8Isl6YtD0LzAudwCdxINBgDIfzfjBnKpbCLt/+bdv4viC/vZkYG x2U7B2WrDZb1mnhAIsc9 =1eq4 -----END PGP SIGNATURE----- --=-=-=--