* [PATCH 0987/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 12:05 Baole Ni
2016-08-02 13:53 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Baole Ni @ 2016-08-02 12:05 UTC (permalink / raw)
To: balbi, gregkh, m.chehab, m.szyprowski, kyungmin.park, k.kozlowski
Cc: linux-usb, linux-kernel, chuansheng.liu, baolex.ni, mina86,
deepa.kernel, mathias.nyman, stern, oneukum
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/usb/phy/phy-twl6030-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
index a72e8d6..4ed75c6 100644
--- a/drivers/usb/phy/phy-twl6030-usb.c
+++ b/drivers/usb/phy/phy-twl6030-usb.c
@@ -208,7 +208,7 @@ static ssize_t twl6030_usb_vbus_show(struct device *dev,
return ret;
}
-static DEVICE_ATTR(vbus, 0444, twl6030_usb_vbus_show, NULL);
+static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, twl6030_usb_vbus_show, NULL);
static irqreturn_t twl6030_usb_irq(int irq, void *_twl)
{
--
2.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 0987/1285] Replace numeric parameter like 0444 with macro
2016-08-02 12:05 [PATCH 0987/1285] Replace numeric parameter like 0444 with macro Baole Ni
@ 2016-08-02 13:53 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2016-08-02 13:53 UTC (permalink / raw)
To: Baole Ni, gregkh, m.chehab, m.szyprowski, kyungmin.park,
k.kozlowski
Cc: linux-usb, linux-kernel, chuansheng.liu, baolex.ni, mina86,
deepa.kernel, mathias.nyman, stern, oneukum
[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]
Baole Ni <baolex.ni@intel.com> writes:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
> drivers/usb/phy/phy-twl6030-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
> index a72e8d6..4ed75c6 100644
> --- a/drivers/usb/phy/phy-twl6030-usb.c
> +++ b/drivers/usb/phy/phy-twl6030-usb.c
> @@ -208,7 +208,7 @@ static ssize_t twl6030_usb_vbus_show(struct device *dev,
>
> return ret;
> }
> -static DEVICE_ATTR(vbus, 0444, twl6030_usb_vbus_show, NULL);
> +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, twl6030_usb_vbus_show, NULL);
line too long
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-02 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-02 12:05 [PATCH 0987/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 13:53 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox