From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbcFFHX4 (ORCPT ); Mon, 6 Jun 2016 03:23:56 -0400 Received: from mga09.intel.com ([134.134.136.24]:63164 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbcFFHXy (ORCPT ); Mon, 6 Jun 2016 03:23:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,426,1459839600"; d="scan'208";a="995989507" From: Jani Nikula To: Vinay Simha BN Cc: open list , "open list\:DRM DRIVERS" , Vinay Simha BN , Archit Taneja Subject: Re: [PATCH 1/2] drm/dsi: Implement set tear scanline In-Reply-To: <1464832099-22402-1-git-send-email-simhavcs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1464832099-22402-1-git-send-email-simhavcs@gmail.com> User-Agent: Notmuch/0.22+12~gbdd9442 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 06 Jun 2016 10:23:49 +0300 Message-ID: <87h9d67pbu.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Jun 2016, Vinay Simha BN wrote: > Provide a small convenience wrapper that transmits > ia set_tear_scanline command as suggested by > Thierry Reding. > > Also includes small build fixes from Sumit Semwal. > > Cc: Archit Taneja > Cc: John Stultz > Cc: Thierry Reding > Cc: Sumit Semwal > Signed-off-by: Vinay Simha BN > --- > drivers/gpu/drm/drm_mipi_dsi.c | 23 +++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 2 ++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index f5d8083..2f0b85c 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -983,6 +983,29 @@ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); > > /** > + * mipi_dsi_set_tear_scanline() - turn on the display module's Tearing Effect > + * output signal on the TE signal line when display module reaches line N > + * defined by STS[n:0]. > + * @dsi: DSI peripheral device > + * @param1: STS[10:8] > + * @param2: STS[7:0] > + * Return: 0 on success or a negative error code on failure > + */ > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, > + u8 param1, u8 param2) If you're making a helper, please make using it easy and have *one* scanline parameter. BR, Jani. > +{ > + u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, param1, param2}; > + ssize_t err; > + > + err = mipi_dsi_generic_write(dsi, &payload, sizeof(payload)); > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_set_tear_scanline); > + > +/** > * mipi_dsi_dcs_set_pixel_format() - sets the pixel format for the RGB image > * data used by the interface > * @dsi: DSI peripheral device > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 7a9840f..2788dbe 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -263,6 +263,8 @@ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, > u16 end); > +int mipi_dsi_set_tear_scanline(struct mipi_dsi_device *dsi, u8 param1, > + u8 param2); > int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > enum mipi_dsi_dcs_tear_mode mode); -- Jani Nikula, Intel Open Source Technology Center