From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, Joao.Pinto@synopsys.com,
sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com,
jun.li@freescale.com, grygorii.strashko@ti.com,
yoshihiro.shimoda.uh@renesas.com, nsekhar@ti.com, b-liu@ti.com,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources
Date: Tue, 10 May 2016 14:48:46 +0300 [thread overview]
Message-ID: <87h9e6gmld.fsf@linux.intel.com> (raw)
In-Reply-To: <5731C9CF.3030303@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
>> Roger Quadros <rogerq@ti.com> writes:
>>>>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>>>>> index 186a886..2e20892 100644
>>>>> --- a/drivers/usb/dwc3/core.h
>>>>> +++ b/drivers/usb/dwc3/core.h
>>>>> @@ -716,6 +716,8 @@ struct dwc3_scratchpad_array {
>>>>> * @maximum_speed: maximum speed requested (mainly for testing purposes)
>>>>> * @revision: revision register contents
>>>>> * @dr_mode: requested mode of operation
>>>>> + * @gadget_irq: IRQ number for Peripheral IRQs
>>>>> + * @otg_irq: IRQ number for OTG IRQs
>>>>> * @usb2_phy: pointer to USB2 PHY
>>>>> * @usb3_phy: pointer to USB3 PHY
>>>>> * @usb2_generic_phy: pointer to USB2 PHY
>>>>> @@ -817,6 +819,9 @@ struct dwc3 {
>>>>>
>>>>> enum usb_dr_mode dr_mode;
>>>>>
>>>>> + int gadget_irq;
>>>>> + int otg_irq;
>>>>
>>>> while at that, let's add host_irq too and do proper changes to dwc3/host.c
>>>
>>> Sure. So we add host_irq here, and manually create an irq resource
>>> in dwc3_host_init?
>>
>> right :-) Then the code looks similar for otg, peripheral and host parts ;-)
>>
> Just saw that host_irq is not used anywhere other than creating the XHCI platform
> device. So I don't see why we need host_irq in struct dwc3.
> It is obtained in dwc3_host_init() and consumed there itself.
fair enough.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2016-05-10 11:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 9:51 [PATCH v7 0/5] dwc3: omap: fixes and dual-role preparation Roger Quadros
2016-05-10 9:51 ` [PATCH v7 1/5] usb: dwc3: omap: use request_threaded_irq() Roger Quadros
2016-05-10 9:58 ` Felipe Balbi
2016-05-10 10:04 ` Roger Quadros
2016-05-10 10:12 ` Felipe Balbi
2016-05-10 10:21 ` Roger Quadros
2016-05-11 8:17 ` Roger Quadros
2016-05-11 9:47 ` Felipe Balbi
2016-05-11 11:46 ` Roger Quadros
2016-05-11 12:39 ` Felipe Balbi
2016-05-11 13:52 ` Roger Quadros
2016-05-10 9:51 ` [PATCH v7 2/5] usb: dwc3: omap: Mark the interrupt handler as shared Roger Quadros
2016-05-10 9:51 ` [PATCH v7 3/5] usb: dwc3: omap: Don't set POWERPRESENT Roger Quadros
2016-05-10 9:54 ` Felipe Balbi
2016-05-10 9:59 ` Roger Quadros
2016-05-10 10:04 ` Felipe Balbi
2016-05-10 10:23 ` Roger Quadros
2016-05-10 10:33 ` Felipe Balbi
2016-05-10 10:24 ` Roger Quadros
2016-05-10 9:51 ` [PATCH v7 4/5] usb: dwc3: omap: Pass VBUS and ID events transparently Roger Quadros
2016-05-10 9:55 ` Felipe Balbi
2016-05-10 10:00 ` Roger Quadros
2016-05-10 10:05 ` Felipe Balbi
2016-05-10 10:13 ` Roger Quadros
2016-05-10 10:13 ` Felipe Balbi
2016-05-10 9:51 ` [PATCH v7 5/5] usb: dwc3: core: cleanup IRQ resources Roger Quadros
2016-05-10 10:03 ` Felipe Balbi
2016-05-10 10:10 ` Roger Quadros
2016-05-10 10:14 ` Felipe Balbi
2016-05-10 11:45 ` Roger Quadros
2016-05-10 11:48 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9e6gmld.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=Joao.Pinto@synopsys.com \
--cc=b-liu@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.chen@freescale.com \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).