From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757499AbcC2QFD (ORCPT ); Tue, 29 Mar 2016 12:05:03 -0400 Received: from down.free-electrons.com ([37.187.137.238]:60449 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757451AbcC2QE7 (ORCPT ); Tue, 29 Mar 2016 12:04:59 -0400 From: Gregory CLEMENT To: Arnd Bergmann Cc: "David S . Miller" , Marcin Wojtas , Evan Wang , netdev@vger.kernel.org, Thomas Petazzoni , Nicolas Schichan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: mvebu-mbus: use %pad to print phys_addr_t References: <1458036233-2770406-1-git-send-email-arnd@arndb.de> Date: Tue, 29 Mar 2016 18:04:47 +0200 In-Reply-To: <1458036233-2770406-1-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 15 Mar 2016 11:03:39 +0100") Message-ID: <87h9fpw9r4.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On mar., mars 15 2016, Arnd Bergmann wrote: > A recent change to the mbus driver added a warning printk that > prints a phys_addr_t using the %x format string, which fails in > case we build with 64-bit phys_addr_t: > > drivers/bus/mvebu-mbus.c: In function 'mvebu_mbus_get_dram_win_info': > drivers/bus/mvebu-mbus.c:975:9: error: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'phys_addr_t {aka long long unsigned int}' [-Werror=format=] > > This uses the special %pa format string instead, so we always > print the correct type. > > Signed-off-by: Arnd Bergmann > Fixes: f2900acea801 ("bus: mvebu-mbus: provide api for obtaining IO > and DRAM window information") What is the status of this patch? Do you plan to send a second version with the title fixed as suggested by Joe Perches? Also do you expect that I collect this patch in the mvebu subsystem? Thanks, Gregory > --- > The warning was introduced in today's linux-next through the net-next > tree, please apply this fixup on top. > > drivers/bus/mvebu-mbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c > index c2e52864bb03..ce54a0160faa 100644 > --- a/drivers/bus/mvebu-mbus.c > +++ b/drivers/bus/mvebu-mbus.c > @@ -972,7 +972,7 @@ int mvebu_mbus_get_dram_win_info(phys_addr_t phyaddr, u8 *target, u8 *attr) > } > } > > - pr_err("invalid dram address 0x%x\n", phyaddr); > + pr_err("invalid dram address %pa\n", &phyaddr); > return -EINVAL; > } > EXPORT_SYMBOL_GPL(mvebu_mbus_get_dram_win_info); > -- > 2.7.0 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com