From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Arun Sharma <asharma@fb.com>, Jiri Olsa <jolsa@redhat.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>
Subject: Re: [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3)
Date: Thu, 19 Dec 2013 16:20:46 +0900 [thread overview]
Message-ID: <87haa5fgs1.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131218174715.GF4819@ghostprotocols.net> (Arnaldo Carvalho de Melo's message of "Wed, 18 Dec 2013 14:47:15 -0300")
On Wed, 18 Dec 2013 14:47:15 -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Dec 18, 2013 at 11:37:49PM +0900, Namhyung Kim escreveu:
>> 2013-12-18 (수), 10:46 +0100, Ingo Molnar:
>> > * Namhyung Kim <namhyung@kernel.org> wrote:
>
>> > > I changed the option as a separate --cumulate and added a new
>> > > "Total" column (and renamed the default "Overhead" column into
>> > > "Self"). The output will be sorted by total (cumulative) overhead
>> > > for now. The reason I changed to the --cumulate is that I still
>> > > think it's much different from other --callchain options and I
>> > > plan to add support for showing (remaining) callchains to
>> > > cumulative entries too. The --callchain option will take care of
>> > > it even with --cumulate option.
>
>> > So I still think this is a fantastic feature, and while this variant
>> > of the user interface is an improvement over the previous version, we
>> > are not there yet ;-)
>>
>> Right. But I want to finish the core part of this patchset first. And
>> then I will work on the UI part since it'll be a quite large work by
>> itself, I guess.
>
> I got the first few ones, that are not really related to this, to reduce
> the patchkit size, will go thru the others next.
Right. I missed to mention that they're independent cleanups, thanks.
>
>> > So the natural way to get this would something like:
>> >
>> > perf report --total
>> >
>> > Or, if '--total' does not feel good, maybe we should change 'Total' to
>> > 'Siblings' or 'Children', and propagate that naming through the UI:
>>
>> Childrend looks better to me.
>
> --children, ack
Okay.
Thanks,
Namhyung
prev parent reply other threads:[~2013-12-19 7:20 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 5:21 [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3) Namhyung Kim
2013-12-18 5:21 ` [PATCH 01/18] perf sort: Compare addresses if no symbol info Namhyung Kim
2013-12-18 15:38 ` Jiri Olsa
2013-12-18 17:35 ` Arnaldo Carvalho de Melo
2013-12-18 17:39 ` Arnaldo Carvalho de Melo
2013-12-19 7:17 ` Namhyung Kim
2014-01-12 18:30 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-12-18 5:21 ` [PATCH 02/18] perf sort: Do not compare dso again Namhyung Kim
2013-12-18 15:40 ` Jiri Olsa
2014-01-12 18:31 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-12-18 5:21 ` [PATCH 03/18] perf tools: Do not pass period and weight to add_hist_entry() Namhyung Kim
2013-12-18 15:41 ` Jiri Olsa
2014-01-12 18:31 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
2013-12-18 5:21 ` [PATCH 04/18] perf tools: Introduce struct add_entry_iter Namhyung Kim
2013-12-18 15:50 ` Jiri Olsa
2013-12-19 7:15 ` Namhyung Kim
2013-12-18 5:21 ` [PATCH 05/18] perf hists: Convert hist entry functions to use struct he_stat Namhyung Kim
2013-12-18 5:21 ` [PATCH 06/18] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2013-12-18 5:21 ` [PATCH 07/18] perf hists: Check if accumulated when adding a " Namhyung Kim
2013-12-18 5:21 ` [PATCH 08/18] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2013-12-18 5:21 ` [PATCH 09/18] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2013-12-18 5:21 ` [PATCH 10/18] perf report: Cache cumulative callchains Namhyung Kim
2013-12-18 5:21 ` [PATCH 11/18] perf hists: Sort hist entries by accumulated period Namhyung Kim
2013-12-18 5:21 ` [PATCH 12/18] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2013-12-18 5:21 ` [PATCH 13/18] perf ui/browser: " Namhyung Kim
2013-12-18 5:21 ` [PATCH 14/18] perf ui/gtk: " Namhyung Kim
2013-12-18 5:21 ` [PATCH 15/18] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2013-12-18 5:21 ` [PATCH 16/18] perf tools: Add more hpp helper functions Namhyung Kim
2013-12-18 5:21 ` [PATCH 17/18] perf report: Add --cumulate option Namhyung Kim
2013-12-18 5:21 ` [PATCH 18/18] perf report: Add report.cumulate config option Namhyung Kim
2013-12-18 9:46 ` [RFC/PATCHSET 00/18] perf report: Add support to accumulate hist periods (v3) Ingo Molnar
2013-12-18 10:38 ` Arun Sharma
2013-12-18 14:39 ` Namhyung Kim
2013-12-23 9:16 ` Arun Sharma
2013-12-24 7:59 ` Namhyung Kim
2013-12-18 14:37 ` Namhyung Kim
2013-12-18 17:47 ` Arnaldo Carvalho de Melo
2013-12-19 7:20 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haa5fgs1.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=asharma@fb.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).