From: Rusty Russell <rusty@rustcorp.com.au>
To: David Cohen <david.a.cohen@intel.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, mark.gross@intel.com
Subject: Re: [PATCH v2] MODSIGN: do not send garbage to stderr when enabling modules signature
Date: Thu, 11 Apr 2013 13:29:09 +0930 [thread overview]
Message-ID: <87hajd4t0y.fsf@rustcorp.com.au> (raw)
In-Reply-To: <51659024.4010405@intel.com>
David Cohen <david.a.cohen@intel.com> writes:
> On 04/10/2013 03:32 AM, Rusty Russell wrote:
>> David Cohen <david.a.cohen@intel.com> writes:
>>> openssl may send garbage to stderr when generating X.509 key pair for
>>> modules signature regardless there was an error or not. It makes more
>>> difficult to create scripts based on kernel error/warning messages.
>>>
>>> When compiling kernel with -jN (N > 1), all warning/error messages
>>> printed while openssl is generating key pair may get mixed dots and
>>> other symbols openssl sends to stderr. This patch makes sure openssl
>>> logs go to default stdout.
>> Ah! Not garbage, but it writes progress dots and status messages to
>> stderr?
>>
>> I trimmed your commit message as shown below.
>
> Thanks! The new commit message looks fine.
> But it's not the dots. It prints the whole logs to stderr, but the dots
> are more likely to get mixed.
>
> Br, David
Seems like Linus didn't bite, so I've put it in my modules-next tree.
Thanks,
Rusty.
prev parent reply other threads:[~2013-04-11 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 21:39 [PATCH v2] MODSIGN: do not send garbage to stderr when enabling modules signature David Cohen
2013-04-09 21:43 ` Gross, Mark
2013-04-10 7:29 ` Rusty Russell
2013-04-10 16:23 ` Gross, Mark
2013-04-10 10:32 ` Rusty Russell
2013-04-10 12:20 ` David Howells
2013-04-10 16:15 ` David Cohen
2013-04-11 3:59 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hajd4t0y.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=david.a.cohen@intel.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox