From: Rusty Russell <rusty@rustcorp.com.au>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>, linux-kernel@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Eric Dumazet <erdnetdev@gmail.com>,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, Wanlong Gao <gaowanlong@cn.fujitsu.com>
Subject: Re: [PATCH V6 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive
Date: Tue, 22 Jan 2013 11:42:40 +1030 [thread overview]
Message-ID: <87hamavx4n.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1358767524-17934-1-git-send-email-gaowanlong@cn.fujitsu.com>
Wanlong Gao <gaowanlong@cn.fujitsu.com> writes:
> As Michael mentioned, set affinity and select queue will not work very
> well when CPU IDs are not consecutive, this can happen with hot unplug.
> Fix this bug by traversal the online CPUs, and create a per cpu variable
> to find the mapping from CPU to the preferable virtual-queue.
This series looks fairly sane at a glance, to me, but MST is the Ack you
need.
Thanks,
Rusty.
next prev parent reply other threads:[~2013-01-22 1:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 11:25 [PATCH V6 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive Wanlong Gao
2013-01-21 11:25 ` [PATCH V6 2/3] virtio-net: split out clean affinity function Wanlong Gao
2013-01-25 3:28 ` Jason Wang
2013-01-25 4:20 ` Wanlong Gao
2013-01-25 5:13 ` Jason Wang
2013-01-25 5:40 ` Wanlong Gao
2013-01-25 6:12 ` Jason Wang
2013-01-25 6:42 ` Wanlong Gao
2013-01-25 7:04 ` Jason Wang
2013-01-25 7:22 ` Wanlong Gao
2013-01-21 11:25 ` [PATCH V6 3/3] virtio-net: reset virtqueue affinity when doing cpu hotplug Wanlong Gao
2013-01-22 1:12 ` Rusty Russell [this message]
2013-01-24 2:28 ` [PATCH V6 1/3] virtio-net: fix the set affinity bug when CPU IDs are not consecutive Wanlong Gao
2013-01-24 17:19 ` Michael S. Tsirkin
2013-01-25 3:26 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hamavx4n.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=erdnetdev@gmail.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox