From: ebiederm@xmission.com (Eric W. Biederman)
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
kexec@lists.infradead.org, xen-devel@lists.xensource.com,
konrad.wilk@oracle.com, tglx@linutronix.de,
maxim.uvarov@oracle.com, andrew.cooper3@citrix.com,
jbeulich@suse.com, mingo@redhat.com, x86@kernel.org,
virtualization@lists.linux-foundation.org, vgoyal@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation
Date: Thu, 27 Dec 2012 19:16:46 -0800 [thread overview]
Message-ID: <87han6n9wh.fsf@xmission.com> (raw)
In-Reply-To: <50DCDBD3.1020703@zytor.com> (H. Peter Anvin's message of "Thu, 27 Dec 2012 15:37:55 -0800")
"H. Peter Anvin" <hpa@zytor.com> writes:
> On 12/27/2012 03:23 PM, Daniel Kiper wrote:
>>> On 12/26/2012 06:18 PM, Daniel Kiper wrote:
>>>> Add i386 kexec/kdump implementation.
>>>>
>>>> v2 - suggestions/fixes:
>>>> - allocate transition page table pages below 4 GiB
>>>> (suggested by Jan Beulich).
>>>
>>> Why?
>>
>> Sadly all addresses are passed via unsigned long
>> variable to kexec hypercall.
>>
>
> So can you unf*ck your broken interface before imposing it on anyone
> else?
Hasn't 32bit dom0 been retired?
Untill the kexec firmware pass through and the normal kexec code paths
are separated I can't make sense out of this code.
The normal kexec code path should be doable without any special
constraints on the kernel. Just leaning on some xen paravirt calls.
The kexec pass through probably should not even touch x86 arch code.
Certainly the same patch should not have code for both the xen kexec
pass through and the paravirt arch code for the normal kexec path.
Eric
next prev parent reply other threads:[~2012-12-28 3:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-27 23:23 [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation Daniel Kiper
2012-12-27 23:37 ` H. Peter Anvin
2012-12-28 3:16 ` Eric W. Biederman [this message]
2013-01-02 14:43 ` [Xen-devel] " Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2012-12-27 2:18 [PATCH v3 00/11] xen: Initial " Daniel Kiper
2012-12-27 2:18 ` [PATCH v3 01/11] kexec: introduce kexec firmware support Daniel Kiper
2012-12-27 2:18 ` [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE Daniel Kiper
2012-12-27 2:18 ` [PATCH v3 03/11] xen: Introduce architecture independent data for kexec/kdump Daniel Kiper
2012-12-27 2:18 ` [PATCH v3 04/11] x86/xen: Introduce architecture dependent " Daniel Kiper
2012-12-27 2:18 ` [PATCH v3 05/11] x86/xen: Register resources required by kexec-tools Daniel Kiper
2012-12-27 2:18 ` [PATCH v3 06/11] x86/xen: Add i386 kexec/kdump implementation Daniel Kiper
2012-12-27 4:00 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87han6n9wh.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=kexec@lists.infradead.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.uvarov@oracle.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).