public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions
Date: Thu, 11 Nov 2010 08:02:27 -0800	[thread overview]
Message-ID: <87hbfnx2zw.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1289484812-17278-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> (Emeltchenko Andrei's message of "Thu, 11 Nov 2010 16:13:32 +0200")

Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> writes:

> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>
> Define MDR1 register serial definitions used in serial and
> bluetooth drivers. Remove magic numbers there.

Remove magic numbers where?  This patch doesn't remove anything.

> *v2	added OMAP keyword

This info should go after the '---' as it is not needed in the final
git history.

Kevin

> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
> ---
>  include/linux/serial_reg.h |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h
> index c7a0ce1..6f38234 100644
> --- a/include/linux/serial_reg.h
> +++ b/include/linux/serial_reg.h
> @@ -341,5 +341,17 @@
>  #define UART_OMAP_SYSS		0x16	/* System status register */
>  #define UART_OMAP_WER		0x17	/* Wake-up enable register */
>  
> +/*
> + * These are the definitions for the MDR1 register
> + */
> +#define UART_OMAP_MDR1_16X_MODE		0x00	/* UART 16x mode */
> +#define UART_OMAP_MDR1_SIR_MODE		0x01	/* SIR mode */
> +#define UART_OMAP_MDR1_16X_ABAUD_MODE	0x02	/* UART 16x auto-baud */
> +#define UART_OMAP_MDR1_13X_MODE		0x03	/* UART 13x mode */
> +#define UART_OMAP_MDR1_MIR_MODE		0x04	/* MIR mode */
> +#define UART_OMAP_MDR1_FIR_MODE		0x05	/* FIR mode */
> +#define UART_OMAP_MDR1_CIR_MODE		0x06	/* CIR mode */
> +#define UART_OMAP_MDR1_DISABLE		0x07	/* Disable (default state) */
> +
>  #endif /* _LINUX_SERIAL_REG_H */

  reply	other threads:[~2010-11-11 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-11 14:13 [PATCHv2] OMAP: Serial: Define OMAP uart MDR1 register definitions Emeltchenko Andrei
2010-11-11 16:02 ` Kevin Hilman [this message]
2010-11-12  7:51   ` Andrei Emeltchenko
2010-11-12 20:25     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbfnx2zw.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox