Re: [stable] 2.6.34.4 build failure

[Sven Joachim <svenjoac@gmx.de>]

On 2010-08-14 23:10 +0200, Greg KH wrote:

> On Sat, Aug 14, 2010 at 08:46:21AM +0200, Sven Joachim wrote:
>> 2.6.34.4 failed to build here:
>> 
>> ,----
>> |   CC      arch/x86/kernel/cpu/vmware.o
>> | arch/x86/kernel/cpu/vmware.c: In function 'vmware_get_tsc_khz':
>> | arch/x86/kernel/cpu/vmware.c:66: error: 'preset_lpj' undeclared (first use in this function)
>> | arch/x86/kernel/cpu/vmware.c:66: error: (Each undeclared identifier is reported only once
>> | arch/x86/kernel/cpu/vmware.c:66: error: for each function it appears in.)
>> | arch/x86/kernel/cpu/vmware.c:68: error: 'HZ' undeclared (first use in this function)
>> | make[3]: *** [arch/x86/kernel/cpu/vmware.o] Error 1
>> | make[2]: *** [arch/x86/kernel/cpu] Error 2
>> | make[1]: *** [arch/x86/kernel] Error 2
>> | make: *** [arch/x86] Error 2
>> `----
>> 
>> The .config file follows.
>
> If you add:
> 	#include <linux/jiffies.h>
> to that file, does it then build?

Yes, that does of course help.

> Odd that this isn't showing up in the .35 kernel :(

I just double-checked whether it was due to some configuration change
that I made, but it wasn't.  Just running 'yes "" | make oldconfig'
produced a configuration that builds with 2.6.35.2.

Anyway, including <linux/jiffies.h> seems to be a reasonable precaution
measure to me, but I'm just a layman.

Regards,
        Sven