From: Andi Kleen <andi@firstfloor.org>
To: Hannes Eder <hannes@hanneseder.net>
Cc: Karsten Keil <kkeil@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] mISDN: fix sparse warnings
Date: Wed, 10 Dec 2008 18:08:24 +0100 [thread overview]
Message-ID: <87hc5cc60n.fsf@basil.nowhere.org> (raw)
In-Reply-To: <493feac3.25e2660a.2824.6cb2@mx.google.com> (Hannes Eder's message of "Wed, 10 Dec 2008 16:43:30 +0100")
Hannes Eder <hannes@hanneseder.net> writes:
> @@ -918,7 +919,7 @@ hfcmulti_resync(struct hfc_multi *locked, struct hfc_multi *newmaster, int rm)
> /* Disable sync of all cards */
> list_for_each_entry_safe(hc, next, &HFClist, list) {
> if (test_bit(HFC_CHIP_PLXSD, &hc->chip)) {
> - plx_acc_32 = (u_int *)(hc->plx_membase+PLX_GPIOC);
> + plx_acc_32 = (u_int __iomem *)(hc->plx_membase+PLX_GPIOC);
It would be probably better to declare plx_membase __iomem too instead
of so much casting.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-12-10 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 15:43 [PATCH 9/9] mISDN: fix sparse warnings Hannes Eder
2008-12-10 17:08 ` Andi Kleen [this message]
2008-12-11 13:41 ` Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hc5cc60n.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hannes@hanneseder.net \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox