From: Johannes Weiner <hannes@saeurebad.de>
To: Ralph Campbell <ralph.campbell@qlogic.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: bug in jiffy time comparison macros
Date: Wed, 11 Jun 2008 04:51:26 +0200 [thread overview]
Message-ID: <87hcc0it01.fsf@saeurebad.de> (raw)
In-Reply-To: <1213144181.5452.26.camel@chromite.mv.qlogic.com> (Ralph Campbell's message of "Tue, 10 Jun 2008 17:29:41 -0700")
Hi,
Ralph Campbell <ralph.campbell@qlogic.com> writes:
> It may just be me :-) but this looks like a bug:
> In the current include/linux/jiffies.h:
>
> #define time_before(a,b) time_after(b,a)
>
> Shouldn't this be:
>
> #define time_before(a,b) time_after_eq(b,a)
Then it would be time_before_eq()..?
If a is before b, b must be after a. If they might be equal, than from
both points of view.
Hannes
prev parent reply other threads:[~2008-06-11 2:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 0:29 bug in jiffy time comparison macros Ralph Campbell
2008-06-11 2:51 ` Johannes Weiner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hcc0it01.fsf@saeurebad.de \
--to=hannes@saeurebad.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralph.campbell@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox