From: Yoann Padioleau <padator@wanadoo.fr>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Yoann Padioleau <padator@wanadoo.fr>,
kernel-janitors@vger.kernel.org, dhowells@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/68] 0 -> NULL, for arch/frv
Date: Fri, 27 Jul 2007 12:21:53 +0200 [thread overview]
Message-ID: <87hcnq9mf2.fsf@wanadoo.fr> (raw)
In-Reply-To: <20070727100004.GV27237@ftp.linux.org.uk> (Al Viro's message of "Fri, 27 Jul 2007 11:00:04 +0100")
Al Viro <viro@ftp.linux.org.uk> writes:
> On Fri, Jul 27, 2007 at 11:44:35AM +0200, Yoann Padioleau wrote:
>> pte = pte_alloc_kernel(pme, va);
>> - if (pte != 0) {
>> + if (pte != NULL) {
>> err = 0;
>> set_pte(pte, mk_pte_phys(pa & PAGE_MASK, prot));
>> }
>> @@ -99,7 +99,7 @@ void *consistent_alloc(gfp_t gfp, size_t
>>
>> /* allocate some common virtual space to map the new pages */
>> area = get_vm_area(size, VM_ALLOC);
>> - if (area == 0) {
>> + if (area == NULL) {
>> free_pages(page, order);
>> return NULL;
>
> Same comment about comparisons with NULL after allocation...
I don't understand. pte is a pointer right ? So why should we
keep the == 0 ?
next prev parent reply other threads:[~2007-07-27 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 9:44 [PATCH 06/68] 0 -> NULL, for arch/frv Yoann Padioleau
2007-07-27 10:00 ` Al Viro
2007-07-27 10:21 ` Yoann Padioleau [this message]
2007-07-27 10:40 ` Al Viro
2007-07-27 10:14 ` David Howells
2007-07-27 10:18 ` Yoann Padioleau
2007-07-28 1:38 ` Robin Getz
2007-07-28 1:37 ` Mike Frysinger
2007-07-31 12:04 ` Richard Knutsson
2007-08-01 10:03 ` Mike Frysinger
2007-08-01 10:38 ` Richard Knutsson
2007-08-01 20:28 ` Matt Mackall
2007-08-02 14:58 ` Robin Getz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hcnq9mf2.fsf@wanadoo.fr \
--to=padator@wanadoo.fr \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox