From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Updated FAT attributes patch
Date: Fri, 04 Feb 2005 21:42:41 +0900 [thread overview]
Message-ID: <87hdkswl6m.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <4202741F.9040102@zytor.com> (H. Peter Anvin's message of "Thu, 03 Feb 2005 10:57:35 -0800")
"H. Peter Anvin" <hpa@zytor.com> writes:
> This updates the FAT attributes as well as (hopefully) corrects the
> handling of VFAT ctime. The FAT attributes are implemented as a
> 32-bit ioctl, per the previous discussions.
[...]
> + /* This MUST be done before doing anything irreversible... */
> + if ( (err = notify_change(filp->f_dentry, &ia)) )
> + goto up;
> +
> + if (sbi->options.sys_immutable) {
> + if ( attr & ATTR_SYS )
> + inode->i_flags |= S_IMMUTABLE;
> + else
> + inode->i_flags &= S_IMMUTABLE;
> + }
> +
> + MSDOS_I(inode)->i_attrs = attr & ATTR_UNUSED;
Looks good to me. However, we would need to add the mark_inode_ditry()
after seting iattr. Because another write_inode() path can clear the
dirty flag before setting ->i_attr.
I'll apply the patch and add it.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2005-02-04 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-03 18:57 [PATCH] Updated FAT attributes patch H. Peter Anvin
2005-02-04 12:42 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hdkswl6m.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox