From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jacky Huang <ychuang3@nuvoton.com>,
Shan-Chun Hung <schung@nuvoton.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Steam Lin <STLin2@winbond.com>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] spi: ma35d1-qspi: Add DTR support
Date: Fri, 14 Aug 2026 14:44:04 +0200 [thread overview]
Message-ID: <87ik5ckh2j.fsf@bootlin.com> (raw)
In-Reply-To: <09c3928f-4b58-4ac6-8e1a-84dfe3ff6b92@sirena.org.uk> (Mark Brown's message of "Thu, 13 Aug 2026 22:33:55 +0100")
>> - ret = nuvoton_qspi_configure_bus(spi, buswidth, dir, xfer->speed_hz);
>> + ret = nuvoton_qspi_configure_bus(spi, buswidth, dir, xfer->speed_hz,
>> + xfer->dtr_mode);
>> if (ret)
>> return ret;
>
> This needs ctlr->dtr_caps configuring, otherwise the validation will
> block it - only the _mem_caps were updated.
Ok, thanks!
next prev parent reply other threads:[~2026-08-14 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 8:00 [PATCH 0/5] spi: ma35d1-qspi: Improvements and DTR support Miquel Raynal
2026-08-13 8:00 ` [PATCH 1/5] spi: ma35d1-qspi: Remove redundant reset operation Miquel Raynal
2026-08-13 8:00 ` [PATCH 2/5] spi: ma35d1-qspi: Move speed setting to bus configuration Miquel Raynal
2026-08-13 8:00 ` [PATCH 3/5] spi: ma35d1-qspi: Allow several command bytes Miquel Raynal
2026-08-13 8:00 ` [PATCH 4/5] spi: ma35d1-qspi: Add DTR support Miquel Raynal
2026-08-13 21:33 ` Mark Brown
2026-08-14 12:44 ` Miquel Raynal [this message]
2026-08-14 12:56 ` Mark Brown
2026-08-13 8:00 ` [PATCH 5/5] spi: ma35d1-qspi: Use the existing update helper Miquel Raynal
2026-08-14 12:38 ` [PATCH 0/5] spi: ma35d1-qspi: Improvements and DTR support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik5ckh2j.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=STLin2@winbond.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=schung@nuvoton.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox