From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93C8837F01D for ; Mon, 15 Jun 2026 08:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781513757; cv=none; b=sh8v0fc8YoezH85/IQmn+eWQ2InTVhfATGt13wKraUYh0pZnlXgt6j4mlZk2xp4Lb6g7d4r9dSRJ022hh1Q+ZanLbhmLCodIkEESyNLHaEpHAdV72DvCm0/+ry4qB7O2D/BsyNfCEyt0G6AV3+L1r1sHAkAblDZQjm2RIy6mtzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781513757; c=relaxed/simple; bh=y+RSyvxzqSLTRpWHELCSRpRh35QUW+qAYU3bsdMcMjU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=AfnRQhOmP7znlLPUfxfreeWgoaEAx6ShFI/rR5wTuY+3F+/8iQwrTZceLol6D5Qx6Y+qmQzaUOi+vhOe9q7kfnW69OeImdyOSqzn7iO5wichbVjoK1DW7x3zmY4YgWF/xHeXVi59JqyAgxWpoeH6cDPg7WNWTXQzcN5rgbc2uA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n3bhxGIX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n3bhxGIX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77FB71F000E9; Mon, 15 Jun 2026 08:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781513756; bh=+15dwgnble0wCZ3JagfnDOLZonAyeju8TDWIimrYT0w=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=n3bhxGIX8J1DdwFwUDhrCGujpIClQzLcEkO5YGPMG8+AT/+vKjonbb9n/fiNtnTHl fwRVZIotEdHlBB9C5v6lc569QCD3mvMRQZ8+na/PJGPRhPKef/cdt/c3yitqyXup7z B5g3uJ40f8Vb7886QZfysf0pKoolE+1H7xCkeWICmH9QBHoPCGU6jTIkpiyDfXRnAK 5Cf7YZTdfW+u2XUBkHh70KGAS9dZeLpx75JMiBk44A/yMysn2z+e0tpTzymdZcR4+6 ixWzYYucsZFeCR5pWL7/CiEmIfIIe+M0V+OEzbZrwhdBjBwRIftCmFwI9QXXQ4/GFV JuZeYYyMWALhw== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wZ36o-0000000CrnC-1oPX; Mon, 15 Jun 2026 08:55:54 +0000 Date: Mon, 15 Jun 2026 09:59:14 +0100 Message-ID: <87ik7k89i5.wl-maz@kernel.org> From: Marc Zyngier To: Kemeng Shi Cc: tglx@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] irqchip/gic-v3-its: Fix memleak in its_probe_one() In-Reply-To: <20260615032910.54735-3-shikemeng@huaweicloud.com> References: <20260615032910.54735-1-shikemeng@huaweicloud.com> <20260615032910.54735-3-shikemeng@huaweicloud.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shikemeng@huaweicloud.com, tglx@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 15 Jun 2026 04:29:06 +0100, Kemeng Shi wrote: > > Fix collection leak when its_init_domain() failed in its_probe_one(). > > Signed-off-by: Kemeng Shi > --- > drivers/irqchip/irq-gic-v3-its.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index 2b7b546c43c8..df26ddc97ae2 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -3032,6 +3032,12 @@ static int its_alloc_collections(struct its_node *its) > return 0; > } > > +static void its_free_collections(struct its_node *its) > +{ > + kfree(its->collections); > + its->collections = NULL; > +} Why do we need an extra helper for something that has a single calling spot? Why is it important to set collections to NULL, given that we're about to free the structure without even looking further? M. -- Jazz isn't dead. It just smells funny.