From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id A87133FE669
	for <linux-kernel@vger.kernel.org>; Mon, 11 May 2026 14:38:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778510335; cv=none; b=SxNkGSYD1lDBQnNvem+hdI5Xvkhvpy9Wu33aN+aYDhw4E5h0tkfH4vBmUHIIb6Q9g5vsmCQtTuL2m/cXoqFyyf8Tk5TNWLEtroV8FyL07zjGDAf6DSQOT2P3y8mwCKdTs5J7Kj7SOOiWp2jjZSyoZX59s27uZiBQTPeX9zxE6II=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778510335; c=relaxed/simple;
	bh=BDZKqrdmcbClRwUMBhZ6Vke7BM3KWXWz1KmpWqnAbuA=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=NKIEePYTbrqtxWNP2ZxyBPdM4avCRT1cu3MV1SmLwWB0e6k8aiDfllpmhGu2rcS/rk23dCMkMaapc2jFya5CBvZtW3vm4qAEm3qwPn04Vl7xFCqJ5bLO9tZY+AM/kds2x42XpqKwuSqAXnbAMiDxbMhtE2itLlQ57xWF2qpDhv8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xg0bGY6K; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xg0bGY6K"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3838C2BCB0;
	Mon, 11 May 2026 14:38:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778510335;
	bh=BDZKqrdmcbClRwUMBhZ6Vke7BM3KWXWz1KmpWqnAbuA=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
	b=Xg0bGY6KFa0n04GS3XF4EzKyIheqJ9zbBJx+uY0doBWl+livUGzW7BWtL7NbkWvbJ
	 ovPwTDBW0BhDknZ8Zn0rUXUcc3/qcoJduiTU6eAXOofE6RizFoKsUPA0nTLVdrrc2b
	 2xOMKQ63pRfDE2wwgUbw7CrE4m61xjXg3UZdpKddbQwgWmdJ5pUKfVeP0+jDZ2Ohmi
	 FJl/zM+v7E+XUzCwZPlt/rFpBj16zDhhseJMiKJ5AICF7W72LAPI9edczJxns0u7ql
	 lUqJq7YJH0PLm4yH/nNq5s25BY90oqd1x1kXcXsdaK48Z3nstEofjwOi2GaDuxfacA
	 X69lW8Ktdk0Tg==
From: Thomas Gleixner <tglx@kernel.org>
To: Radu Rendec <radu@rendec.net>, LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Michael Kelley <mhklinux@outlook.com>, Dmitry Ilvokhin
 <d@ilvokhin.com>, Jan Kiszka <jan.kiszka@siemens.com>, Kieran Bingham
 <kbingham@kernel.org>, Florian Fainelli <florian.fainelli@broadcom.com>,
 Marc Zyngier <maz@kernel.org>
Subject: Re: [patch V5 05/15] x86/irq: Suppress unlikely interrupt stats by
 default
In-Reply-To: <bb079a11992a63b30b23de438648932182a351ca.camel@rendec.net>
References: <20260401195625.213446764@kernel.org>
 <20260401201348.355938635@kernel.org>
 <bb079a11992a63b30b23de438648932182a351ca.camel@rendec.net>
Date: Mon, 11 May 2026 16:38:52 +0200
Message-ID: <87ik8u80zn.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Thu, Apr 02 2026 at 12:39, Radu Rendec wrote:
>> -	inc_irq_stat(SPURIOUS);
>> +	irq_stat_inc_and_enable(IRQ_COUNT_SPURIOUS);
>
> This is just a matter of style but for symmetry with inc_irq_stat(), I
> would prepend '__' to the function name and create a wrapper macro that
> adds the 'IRQ_COUNT_' prefix.
>
> And for consistency (you also have inc_perf_irq_stat()) I would call it
> inc_and_enable_irq_stat().

I fundamentaly despise these constructs which do not have a proper name
space prefix. They make it just hard to grep for. Yes, inc_irq_stat()
exists already, but that does not mean we need to proliferate it.

Thanks,

        tglx