public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] ALSA: hda: allocate nodes with tree
Date: Mon, 27 Apr 2026 13:55:17 +0200	[thread overview]
Message-ID: <87ik9czkgq.wl-tiwai@suse.de> (raw)
In-Reply-To: <87se8gzku7.wl-tiwai@suse.de>

On Mon, 27 Apr 2026 13:47:12 +0200,
Takashi Iwai wrote:
> 
> On Sat, 25 Apr 2026 04:34:21 +0200,
> Rosen Penev wrote:
> > 
> > Use a flexible array member to combine allocations. Simplifies
> > allocation and freeing.
> > 
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> 
> Applied to for-next branch now.  Thanks.

Scratch that.  I re-read the code, and noticed that it doesn't handle
the case in hda_widget_sysfs_reinit().  It can resize and reallocate
the node table, hence the embedded flex array won't work.


thanks,

Takashi

      reply	other threads:[~2026-04-27 11:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  2:34 [PATCH] ALSA: hda: allocate nodes with tree Rosen Penev
2026-04-27 11:47 ` Takashi Iwai
2026-04-27 11:55   ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik9czkgq.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=rosenp@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox