[PATCH v2 0/4] Fixes for EIP97/EIP197 binding and devicetrees

[PATCH v2 0/4] Fixes for EIP97/EIP197 binding and devicetrees

[AngeloGioacchino Del Regno]

Changes in v2:
 - Reorder commits
 - Change to restrict interrupts/interrupt-names minItems to MediaTek only

This series adds SoC compatibles to the EIP97/EIP197 binding, and also
fixes all of the devicetrees to actually declare those in their nodes.

The only platforms using this binding are Marvell and MediaTek.

AngeloGioacchino Del Regno (4):
  dt-bindings: crypto: inside-secure,safexcel: Add SoC compatibles
  dt-bindings: crypto: inside-secure,safexcel: Mandate only ring IRQs
  arm64: dts: marvell: Add SoC specific compatibles to SafeXcel crypto
  arm64: dts: mediatek: mt7986a: Change compatible for SafeXcel crypto

 .../crypto/inside-secure,safexcel.yaml        | 22 +++++++++++++++++++
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |  3 ++-
 arch/arm64/boot/dts/marvell/armada-cp11x.dtsi |  3 ++-
 arch/arm64/boot/dts/mediatek/mt7986a.dtsi     |  2 +-
 4 files changed, 27 insertions(+), 3 deletions(-)

-- 
2.52.0

[PATCH v2 1/4] dt-bindings: crypto: inside-secure,safexcel: Add SoC compatibles

[AngeloGioacchino Del Regno]

Add SoC specific compatibles for the SafeXcel crypto engine,
including one for the EIP197B used by Marvell Armada CP110 and
and two for the EIP97IES used by Marvell Armada 3700 and by
MediaTek MT7986.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../bindings/crypto/inside-secure,safexcel.yaml           | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml
index 343e2d04c797..1c8bfd6c958d 100644
--- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml
+++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml
@@ -12,6 +12,14 @@ maintainers:
 properties:
   compatible:
     oneOf:
+      - items:
+          - const: marvell,armada-cp110-crypto
+          - const: inside-secure,safexcel-eip197b
+      - items:
+          - enum:
+              - marvell,armada-3700-crypto
+              - mediatek,mt7986-crypto
+          - const: inside-secure,safexcel-eip97ies
       - const: inside-secure,safexcel-eip197b
       - const: inside-secure,safexcel-eip197d
       - const: inside-secure,safexcel-eip97ies
-- 
2.52.0

Re: [PATCH v2 1/4] dt-bindings: crypto: inside-secure,safexcel: Add SoC compatibles

[Rob Herring (Arm)]

On Mon, 12 Jan 2026 15:55:55 +0100, AngeloGioacchino Del Regno wrote:
> Add SoC specific compatibles for the SafeXcel crypto engine,
> including one for the EIP197B used by Marvell Armada CP110 and
> and two for the EIP97IES used by Marvell Armada 3700 and by
> MediaTek MT7986.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../bindings/crypto/inside-secure,safexcel.yaml           | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH v2 2/4] dt-bindings: crypto: inside-secure,safexcel: Mandate only ring IRQs

[AngeloGioacchino Del Regno]

Not all IP implementations of EIP97 and EIP197 have the EIP and
MEM interrupts hooked up to the SoC, and those are not required
for functionality as status for both can be polled (and anyway
there's even no real need to poll, but that's another story).

As an example of this, the MediaTek MT7986A and MT7986B SoCs do
not have those two interrupts hooked up to their irq controlller.

For this reason, make the EIP and MEM interrupt optional on the
mediatek,mt7986-crypto.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../bindings/crypto/inside-secure,safexcel.yaml    | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml
index 1c8bfd6c958d..3dc6c5f89d32 100644
--- a/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml
+++ b/Documentation/devicetree/bindings/crypto/inside-secure,safexcel.yaml
@@ -34,9 +34,11 @@ properties:
     maxItems: 1
 
   interrupts:
+    minItems: 4
     maxItems: 6
 
   interrupt-names:
+    minItems: 4
     items:
       - const: ring0
       - const: ring1
@@ -73,6 +75,18 @@ allOf:
           minItems: 2
       required:
         - clock-names
+  - if:
+      properties:
+        compatible:
+          not:
+            contains:
+              const: mediatek,mt7986-crypto
+    then:
+      properties:
+        interrupts:
+          minItems: 6
+        interrupt-names:
+          minItems: 6
 
 additionalProperties: false
 
-- 
2.52.0

Re: [PATCH v2 2/4] dt-bindings: crypto: inside-secure,safexcel: Mandate only ring IRQs

[Rob Herring (Arm)]

On Mon, 12 Jan 2026 15:55:56 +0100, AngeloGioacchino Del Regno wrote:
> Not all IP implementations of EIP97 and EIP197 have the EIP and
> MEM interrupts hooked up to the SoC, and those are not required
> for functionality as status for both can be polled (and anyway
> there's even no real need to poll, but that's another story).
> 
> As an example of this, the MediaTek MT7986A and MT7986B SoCs do
> not have those two interrupts hooked up to their irq controlller.
> 
> For this reason, make the EIP and MEM interrupt optional on the
> mediatek,mt7986-crypto.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../bindings/crypto/inside-secure,safexcel.yaml    | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH v2 3/4] arm64: dts: marvell: Add SoC specific compatibles to SafeXcel crypto

[AngeloGioacchino Del Regno]

Following the changes in the binding for the SafeXcel crypto
engine, add SoC specific compatibles to the existing nodes in
Armada 37xx and CP11x.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/marvell/armada-37xx.dtsi  | 3 ++-
 arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index c612317043ea..87f9367aec12 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -427,7 +427,8 @@ xor11 {
 			};
 
 			crypto: crypto@90000 {
-				compatible = "inside-secure,safexcel-eip97ies";
+				compatible = "marvell,armada-3700-crypto",
+					     "inside-secure,safexcel-eip97ies";
 				reg = <0x90000 0x20000>;
 				interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
 					     <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
index d9d409eac259..39599171d51b 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
@@ -512,7 +512,8 @@ CP11X_LABEL(sdhci0): mmc@780000 {
 		};
 
 		CP11X_LABEL(crypto): crypto@800000 {
-			compatible = "inside-secure,safexcel-eip197b";
+			compatible = "marvell,armada-cp110-crypto",
+				     "inside-secure,safexcel-eip197b";
 			reg = <0x800000 0x200000>;
 			interrupts = <88 IRQ_TYPE_LEVEL_HIGH>,
 				<89 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.52.0

Re: [PATCH v2 3/4] arm64: dts: marvell: Add SoC specific compatibles to SafeXcel crypto

[Gregory CLEMENT]

AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
writes:

> Following the changes in the binding for the SafeXcel crypto
> engine, add SoC specific compatibles to the existing nodes in
> Armada 37xx and CP11x.
>

Applied on mvebu/dt64

Thanks,

Gregory

> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi  | 3 ++-
>  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index c612317043ea..87f9367aec12 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -427,7 +427,8 @@ xor11 {
>  			};
>  
>  			crypto: crypto@90000 {
> -				compatible = "inside-secure,safexcel-eip97ies";
> +				compatible = "marvell,armada-3700-crypto",
> +					     "inside-secure,safexcel-eip97ies";
>  				reg = <0x90000 0x20000>;
>  				interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
>  					     <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index d9d409eac259..39599171d51b 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -512,7 +512,8 @@ CP11X_LABEL(sdhci0): mmc@780000 {
>  		};
>  
>  		CP11X_LABEL(crypto): crypto@800000 {
> -			compatible = "inside-secure,safexcel-eip197b";
> +			compatible = "marvell,armada-cp110-crypto",
> +				     "inside-secure,safexcel-eip197b";
>  			reg = <0x800000 0x200000>;
>  			interrupts = <88 IRQ_TYPE_LEVEL_HIGH>,
>  				<89 IRQ_TYPE_LEVEL_HIGH>,
> -- 
> 2.52.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[PATCH v2 4/4] arm64: dts: mediatek: mt7986a: Change compatible for SafeXcel crypto

[AngeloGioacchino Del Regno]

Following the changes in the binding for the SafeXcel crypto
engine, add a SoC specific compatible to the existing crypto
node and, while at it, also change the fallback compatible to
inside-secure,safexcel-eip97ies as the eip97 one is deprecated.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
index 7790601586cc..9693f62fd013 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
@@ -231,7 +231,7 @@ trng: rng@1020f000 {
 		};
 
 		crypto: crypto@10320000 {
-			compatible = "inside-secure,safexcel-eip97";
+			compatible = "mediatek,mt7986-crypto", "inside-secure,safexcel-eip97ies";
 			reg = <0 0x10320000 0 0x40000>;
 			interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
-- 
2.52.0

Re: (subset) [PATCH v2 0/4] Fixes for EIP97/EIP197 binding and devicetrees

[AngeloGioacchino Del Regno]

On Mon, 12 Jan 2026 15:55:54 +0100, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>  - Reorder commits
>  - Change to restrict interrupts/interrupt-names minItems to MediaTek only
> 
> This series adds SoC compatibles to the EIP97/EIP197 binding, and also
> fixes all of the devicetrees to actually declare those in their nodes.
> 
> [...]

Applied to v6.19-next/dts64, thanks!

[4/4] arm64: dts: mediatek: mt7986a: Change compatible for SafeXcel crypto
      commit: 32c5491a8d73713578560f515cccd4e9460d156d

Cheers,
Angelo

Re: [PATCH v2 0/4] Fixes for EIP97/EIP197 binding and devicetrees

[Rob Herring]

On Mon, Jan 12, 2026 at 03:55:54PM +0100, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>  - Reorder commits
>  - Change to restrict interrupts/interrupt-names minItems to MediaTek only
> 
> This series adds SoC compatibles to the EIP97/EIP197 binding, and also
> fixes all of the devicetrees to actually declare those in their nodes.
> 
> The only platforms using this binding are Marvell and MediaTek.
> 
> AngeloGioacchino Del Regno (4):
>   dt-bindings: crypto: inside-secure,safexcel: Add SoC compatibles
>   dt-bindings: crypto: inside-secure,safexcel: Mandate only ring IRQs

I applied these 2.

Rob

Re: [PATCH v2 0/4] Fixes for EIP97/EIP197 binding and devicetrees

[Herbert Xu]

On Mon, Jan 12, 2026 at 03:55:54PM +0100, AngeloGioacchino Del Regno wrote:
> Changes in v2:
>  - Reorder commits
>  - Change to restrict interrupts/interrupt-names minItems to MediaTek only
> 
> This series adds SoC compatibles to the EIP97/EIP197 binding, and also
> fixes all of the devicetrees to actually declare those in their nodes.
> 
> The only platforms using this binding are Marvell and MediaTek.
> 
> AngeloGioacchino Del Regno (4):
>   dt-bindings: crypto: inside-secure,safexcel: Add SoC compatibles
>   dt-bindings: crypto: inside-secure,safexcel: Mandate only ring IRQs
>   arm64: dts: marvell: Add SoC specific compatibles to SafeXcel crypto
>   arm64: dts: mediatek: mt7986a: Change compatible for SafeXcel crypto
> 
>  .../crypto/inside-secure,safexcel.yaml        | 22 +++++++++++++++++++
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |  3 ++-
>  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi |  3 ++-
>  arch/arm64/boot/dts/mediatek/mt7986a.dtsi     |  2 +-
>  4 files changed, 27 insertions(+), 3 deletions(-)
> 
> -- 
> 2.52.0

Patches 1-2 applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/4] Fixes for EIP97/EIP197 binding and devicetrees

[Herbert Xu]

On Sat, Jan 31, 2026 at 10:51:11AM +0800, Herbert Xu wrote:
> On Mon, Jan 12, 2026 at 03:55:54PM +0100, AngeloGioacchino Del Regno wrote:
> > Changes in v2:
> >  - Reorder commits
> >  - Change to restrict interrupts/interrupt-names minItems to MediaTek only
> > 
> > This series adds SoC compatibles to the EIP97/EIP197 binding, and also
> > fixes all of the devicetrees to actually declare those in their nodes.
> > 
> > The only platforms using this binding are Marvell and MediaTek.
> > 
> > AngeloGioacchino Del Regno (4):
> >   dt-bindings: crypto: inside-secure,safexcel: Add SoC compatibles
> >   dt-bindings: crypto: inside-secure,safexcel: Mandate only ring IRQs
> >   arm64: dts: marvell: Add SoC specific compatibles to SafeXcel crypto
> >   arm64: dts: mediatek: mt7986a: Change compatible for SafeXcel crypto
> > 
> >  .../crypto/inside-secure,safexcel.yaml        | 22 +++++++++++++++++++
> >  arch/arm64/boot/dts/marvell/armada-37xx.dtsi  |  3 ++-
> >  arch/arm64/boot/dts/marvell/armada-cp11x.dtsi |  3 ++-
> >  arch/arm64/boot/dts/mediatek/mt7986a.dtsi     |  2 +-
> >  4 files changed, 27 insertions(+), 3 deletions(-)
> > 
> > -- 
> > 2.52.0
> 
> Patches 1-2 applied.  Thanks.

Oops, they've already been applied elsewhere so I'm backing them
out of cryptodev.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt