From: Takashi Iwai <tiwai@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, Nikhil Mahale <nmahale@nvidia.com>
Subject: Re: [PATCH] ALSA: hda - fix function names & missing function parameter
Date: Wed, 07 Jan 2026 09:06:21 +0100 [thread overview]
Message-ID: <87ikddetj6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260106185951.2179242-1-rdunlap@infradead.org>
On Tue, 06 Jan 2026 19:59:51 +0100,
Randy Dunlap wrote:
>
> Use the correct function names and add a function parameter description
> to avoid kernel-doc warnings:
>
> hda_jack.h:97: warning: Function parameter or struct member 'cb' not
> described in 'snd_hda_jack_detect_enable_callback'
> hda_jack.h:97: warning: expecting prototype for snd_hda_jack_detect_enable().
> Prototype was for snd_hda_jack_detect_enable_callback() instead
> hda_local.h:441: warning: expecting prototype for _snd_hda_set_pin_ctl().
> Prototype was for snd_hda_set_pin_ctl() instead
>
> Fixes: cdd03cedc5b5 ("ALSA: hda - Introduce snd_hda_set_pin_ctl*() helper functions")
> Fixes: 5204a05d70d9 ("ALSA: hda - Add DP-MST jack support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-01-07 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 18:59 [PATCH] ALSA: hda - fix function names & missing function parameter Randy Dunlap
2026-01-07 8:06 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikddetj6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nmahale@nvidia.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox