From: Takashi Iwai <tiwai@suse.de>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: perex@perex.cz, tiwai@suse.com, cristian.ciocaltea@collabora.com,
franta-linux@frantovo.cz, lina+kernel@asahilina.net,
livvy@base.nu, sstistrup@gmail.com, s@srd.tw,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Convert comma to semicolon
Date: Thu, 12 Jun 2025 08:52:44 +0200 [thread overview]
Message-ID: <87ikl1v4cj.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250612060228.1518028-1-nichen@iscas.ac.cn>
On Thu, 12 Jun 2025 08:02:28 +0200,
Chen Ni wrote:
>
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Thanks, applied now.
At the next time, though, it'd be appreciated if you can put the
proper Fixes tag.
Takashi
next prev parent reply other threads:[~2025-06-12 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 6:02 [PATCH] ALSA: usb-audio: Convert comma to semicolon Chen Ni
2025-06-12 6:13 ` Cristian Ciocaltea
2025-06-12 6:52 ` Takashi Iwai [this message]
2025-06-12 7:22 ` Cristian Ciocaltea
2025-06-12 7:30 ` Takashi Iwai
2025-06-12 7:48 ` Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikl1v4cj.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cristian.ciocaltea@collabora.com \
--cc=franta-linux@frantovo.cz \
--cc=lina+kernel@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=livvy@base.nu \
--cc=nichen@iscas.ac.cn \
--cc=perex@perex.cz \
--cc=s@srd.tw \
--cc=sstistrup@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).