From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A14BEA937 for ; Tue, 3 Jun 2025 13:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748957265; cv=none; b=rUE1ZJEyOk11dzw9GRQMs56W+wMQDd1kjSzcgEZrIo9zRcxAsG8/e8jffvRxWTGjttX237o6GmvWhpotF/NTCncnF8fKJ7NNw/9k8ZOtKKigxwG9+KQ2LcA/qtHVHdxPtFKkWkFzplgCtSuaTKly7Slu0EoKPEZG5p17W9v10JA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748957265; c=relaxed/simple; bh=Xp5tz2MBWTFRNuYRCISAwmh9P/iygUJfc9k7rU5xBQw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=TXc9k6Z6IxBIZlTuN4JRW9f3Hqm8Oi5Hq0RFfwANpQMO5oSGwtuiK1Xxgt5IHtsnVq9Wwtrz8UxQ8mLXLSgQ+rBGZE6fA2kSTMPA7FbL3Ph0fFvb8h3iQ/OPvv3WsWuC3SzbbfeGWyvCi6jgBcerEnhATgjvg4uTXMMoB+ngS7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pvc19Czn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pvc19Czn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9239C4CEED; Tue, 3 Jun 2025 13:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748957263; bh=Xp5tz2MBWTFRNuYRCISAwmh9P/iygUJfc9k7rU5xBQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Pvc19CznMU5E1OAFpXn3B8++W0mZpQpcdkXK0Q4pwHZg/5G3OtvqxyecS9ue6oi5O KhlD4LK1GwjSmGCF1/qGr1jcRRyt1H5ndOPTfrnoAqZEdH4lew91s5Oa0idcsNH1oH 7fzhJnpMzzruywCFhZVUjBm3ZEpUZ4qv1J6PtpNBiT4+4+AEo4DDiS8EGKNetnQamj KotAjZOwzeoUshRucyqgkwKC3UauVGwBv1rJL2aK0RmmBewPK9Equpc5ddnu0ZKHEh /qAnYI+cfDhD8Wuu4SfAgHs2585wD1uCUWZm7Cdwj6WnWSYh4+AWN+PrnUZhEpCdBL xI5/wve4dO1Ng== Received: from [149.88.19.236] (helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uMRg4-002qIm-DF; Tue, 03 Jun 2025 14:27:40 +0100 Date: Tue, 03 Jun 2025 14:27:38 +0100 Message-ID: <87iklddkfp.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Cc: , , Thomas Gleixner , Lorenzo Pieralisi , Sascha Bischoff , Timothy Hayes Subject: Re: [PATCH v2 3/5] genirq/msi: Move prepare() call to per-device allocation In-Reply-To: References: <20250513163144.2215824-1-maz@kernel.org> <20250513163144.2215824-4-maz@kernel.org> <0b1d7aec-1eac-a9cd-502a-339e216e08a1@huawei.com> <87ldq9dm54.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 149.88.19.236 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, lpieralisi@kernel.org, sascha.bischoff@arm.com, timothy.hayes@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 03 Jun 2025 14:07:04 +0100, Zenghui Yu wrote: > > Hi Marc, > > On 2025/6/3 20:50, Marc Zyngier wrote: > > Hi Zenghui, > > > > On Tue, 03 Jun 2025 09:22:47 +0100, > > Zenghui Yu wrote: > > > > > > > + domain->dev = dev; > > > > + dev->msi.data->__domains[domid].domain = domain; > > > > + > > > > + if (msi_domain_prepare_irqs(domain, dev, hwsize, &bundle->alloc_info)) { > > > > > > Does it work for MSI? hwsize is 1 in the MSI case, without taking > > > pci_msi_vec_count() into account. > > > > > > bool pci_setup_msi_device_domain(struct pci_dev *pdev) > > > { > > > [...] > > > > > > return pci_create_device_domain(pdev, &pci_msi_template, 1); > > > > Well spotted. > > > > This looks like a PCI bug ignoring Multi-MSI. Can you give the > > following a go and let people know whether that fixes your issue? > > I hit this problem on Kunpeng920 with some HiSilicon SAS (Serial > Attached SCSI controller) on it. These controllers are MSI-capable and > didn't work after this commit. That's interesting. It means that the sizing of the irqdomain to 1 wasn't getting in the way, even if that was obviously wrong. The funny thing is that the msi_desc would still be OK, as we only have one for MSI, no matter how many vectors are used. > > I have the exact same diff to get my box to work again ;-) Ah ;-) > > Tested-by: Zenghui Yu > > Thanks for your fix! Thank you! M. -- Jazz isn't dead. It just smells funny.