Re: [PATCH 1/2] mtd: spi-nor: sst: register SFDP region into NVMEM framework to read MAC Address

kernel test robot
2025-03-06T04:25:57Z

Hi Manikandan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mtd/spi-nor/next]
[also build test WARNING on robh/for-next abelloni/rtc-next linus/master v6.14-rc5 next-20250305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Manikandan-Muralidharan/ARM-dts-microchip-sama5d29_curiosity-Add-nvmem-layout-in-QSPI-to-describe-EUI48-MAC-address-region/20250305-180433
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git spi-nor/next
patch link: https://lore.kernel.org/r/20250305100134.1171124-1-manikandan.m%40microchip.com
patch subject: [PATCH 1/2] mtd: spi-nor: sst: register SFDP region into NVMEM framework to read MAC Address
config: m68k-stmark2_defconfig (https://download.01.org/0day-ci/archive/20250306/202503061244.wH2sylN8-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250306/202503061244.wH2sylN8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503061244.wH2sylN8-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mtd/spi-nor/sst.c:75: warning: Function parameter or struct member 'off' not described in 'sst26vf_sfdp_mac_addr_read'
>> drivers/mtd/spi-nor/sst.c:75: warning: Excess function parameter 'offset' description in 'sst26vf_sfdp_mac_addr_read'

vim +75 drivers/mtd/spi-nor/sst.c

61
62 /**
63 * sst26vf_sfdp_mac_addr_read() - check if the EUI-48 MAC Address is programmed
64 * and read the data from the prestored SFDP data
65 *
66 * @priv: User context passed to read callbacks.
67 * @offset: Offset within the NVMEM device.
68 * @val: pointer where to fill the ethernet address
69 * @bytes: Length of the NVMEM cell
70 *
71 * Return: 0 on success, -EINVAL otherwise.
72 */
73 static int sst26vf_sfdp_mac_addr_read(void *priv, unsigned int off,
74 void *val, size_t bytes)
> 75 {
76 struct spi_nor *nor = priv;
77 struct sfdp *sfdp = nor->sfdp;
78 loff_t offset = off;
79 size_t sfdp_size;
80
81 /*
82 * Check if the EUI-48 MAC address is programmed in the next six address
83 * locations.
84 * @off is programmed in the DT and stores the start of MAC Address
85 * byte, (off - 1) stores the bit length of the Extended Unique
86 * Identifier
87 */
88 if (SST26VF_SFDP_EUI48 != *((u8 *)sfdp->dwords + (offset - 1)))
89 return -EINVAL;
90
91 sfdp_size = sfdp->num_dwords * sizeof(*sfdp->dwords);
92 memory_read_from_buffer(val, bytes, &offset, sfdp->dwords,
93 sfdp_size);
94 return 0;
95 }
96

--
0-DAY CI Kernel Test Service