From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9604B29D19 for ; Mon, 13 Jan 2025 15:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782418; cv=none; b=RLS2GdjcgZ/bCk0/utP+znfxCxyY8cVVVkCXoLzASE0d24VvS16aQ7GPToJGTgTGyp1xMBFUhhnbDfyQQQdi0ba/Xw7El2uz0xM5qpHrbaY5r2pGdYlZu0yy7gRSLyEhJLypw8W7XA8RZYMnJBVfAfOYCXD7MjTOaahOVgHAksc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736782418; c=relaxed/simple; bh=L9dE/J3HLeGi0meZQC+fcH8OdnY1ORq9PmP34QD6tvY=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=ca00nU2OuhyGoaNzx/OHsqol9qaXtGcIU9Tvx+30RpRK5bRnxAFDEYj/3rQ9Ww6gorQ58/3VonBF1gLN1GeOKNcw262AMOzVjnQ7XvQw5P1mYnhxsTNC60YdmGVnM/or+qoveGi4nuY8o5gf6KjL8sEGMF7cjoGPfFoowg8GCtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KgNw6vPG; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgNw6vPG" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2164b662090so73870385ad.1 for ; Mon, 13 Jan 2025 07:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736782415; x=1737387215; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=nS0VW7OpusrmvoM1qKliuIyxx2VelfJHJPe+7ERDfnk=; b=KgNw6vPGW5GMccZevM+xTy7yc751EWSIk2wkqCdZPQ9hz2eCAvAFpDmjm0DHjy+40Z dDi+uKQomZm0XR2i8gz9/hVABWa0LhZlQc/yfjQjln/hFoS0Cac3OtA/oi1SeUpeK+8j j51lLbgJ2n2wG0rMSk+DZ1GvqSiJ3oqOD+IuoN6b33ZTzp4z+8BFgVGHDYYD7oGRTmR8 kimxkPte+mH/3C45jMoNk0rcIxWILwFn3VohK1UD6SRx9nS3TGIf6UB76N6wIBgGdlnL 595srmSDJTXk+EiLhPTDZgsPu803ATjMcqAT8ZtfAUKUBnqBJs9Bn90h4W8cYXRIiKtX k9xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736782415; x=1737387215; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nS0VW7OpusrmvoM1qKliuIyxx2VelfJHJPe+7ERDfnk=; b=lKlF7SmwQQre9gLOYBwmh6Pw0pzCicRNYPiaofyjtKDl8g1GIu1SjGRkyqVv31rx2t +IqLQOvYCFMgUr/yR1y/MPaeW+WOnmMAwwTefXu/l543JqVpA7yw6u6dCSVDW2CVvuai aS946YRNWIlymQ8T5RorYFCRkhkBGtAayT03JzRdYZtrSoZF9Qyqbxa2YqXrx3XRQYTU qt37tFCU5jf3Ijne4psa9xeLha1Tv9aBaA9PAV/4PNwofkHR5iVPGIxYvA0q5K506lRA rmzBpPhg1EWenBQUNfpzfPUo5XalKFh5Kf3j1dyH7O+XoyGGuT70RDZXDKOAekJUhRcd T03w== X-Forwarded-Encrypted: i=1; AJvYcCWEr2+FqznQEPQFlfBM6vl0mtL8EKOgUrfFARDxDbZnDjeYitWj+N/HHxdbglryKBAPotE+zgSSUjJVKSE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz7Ys4v51U4fy+TSEBMIYKyqQMu2HL4EKKLffhouhv/n1HKTTr PP3haLnDuDFpzXOugQKzwLnJR8moueo7EsHEvnyV2ypCkrbpUIBNdj4VjA== X-Gm-Gg: ASbGncuuwzEAk8ytZkLAWndLOMLkRacPae+R+x8xFrT8VOLFKJ9mARKt65Cs2jXua1b gdYt8AZuYlJ9sQjyzWjd+82wH9CpJZVw19buUs87Ff7yiTkhKX6ou0U0TReHyTuAxRjgsMJp716 EVdPc8ELuP48+ttlrTdUW9eztCCjdG1Zwruxv3pq4mnpJiAYDImRhH4MIrdx5zX8kwvX+Wkz+dC QWdmYBq1LSLCjYT3kXqB9oQr2UVjPYGcFKOHRpgDbMQx9Gp X-Google-Smtp-Source: AGHT+IFPqNgyn5QTfzD6MCfqvWw0Y/BlmXEY4FXRiNw3UKd4U8IM3kOvttZByuZ+r1aCmyFZbJ+JCA== X-Received: by 2002:a17:902:db0a:b0:212:996:3536 with SMTP id d9443c01a7336-21a83f4b11bmr357643555ad.10.1736782415029; Mon, 13 Jan 2025 07:33:35 -0800 (PST) Received: from dw-tp ([171.76.81.42]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f21a04dsm55322025ad.151.2025.01.13.07.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2025 07:33:34 -0800 (PST) From: Ritesh Harjani (IBM) To: Thorsten Blum , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Hari Bathini , Sourabh Jain , Bjorn Helgaas , "Aneesh Kumar K.V (IBM)" Cc: Thorsten Blum , Baoquan He , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fadump: Use str_yes_no() helper in fadump_show_config() In-Reply-To: <20241230214142.952706-2-thorsten.blum@linux.dev> Date: Mon, 13 Jan 2025 20:39:53 +0530 Message-ID: <87ikqivjge.fsf@gmail.com> References: <20241230214142.952706-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thorsten Blum writes: > Remove hard-coded strings by using the str_yes_no() helper function. > > Signed-off-by: Thorsten Blum > --- > arch/powerpc/kernel/fadump.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) In fadump.c file we have implicit include of string_choices.h i.e. include/linux/seq_file.h -> linux/string_helpers.h -> linux/string_choices.h Directly having string_choices include could be better. #include However no hard preferences. The patch functionally looks correct to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) > > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index 4b371c738213..8c531533dd3e 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -289,10 +289,8 @@ static void __init fadump_show_config(void) > if (!fw_dump.fadump_supported) > return; > > - pr_debug("Fadump enabled : %s\n", > - (fw_dump.fadump_enabled ? "yes" : "no")); > - pr_debug("Dump Active : %s\n", > - (fw_dump.dump_active ? "yes" : "no")); > + pr_debug("Fadump enabled : %s\n", str_yes_no(fw_dump.fadump_enabled)); > + pr_debug("Dump Active : %s\n", str_yes_no(fw_dump.dump_active)); > pr_debug("Dump section sizes:\n"); > pr_debug(" CPU state data size: %lx\n", fw_dump.cpu_state_data_size); > pr_debug(" HPTE region size : %lx\n", fw_dump.hpte_region_size); > -- > 2.47.1