Re: [PATCH] fadump: Use str_yes_no() helper in fadump_show_config()

Ritesh Harjani
2025-01-13T15:33:36Z

Thorsten Blum <thorsten.blum@linux.dev> writes:

> Remove hard-coded strings by using the str_yes_no() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/powerpc/kernel/fadump.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

In fadump.c file we have implicit include of string_choices.h i.e.

include/linux/seq_file.h -> linux/string_helpers.h -> linux/string_choices.h

Directly having string_choices include could be better.
#include <linux/string_choices.h>

However no hard preferences. The patch functionally looks correct to me.

Please feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

>
> diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
> index 4b371c738213..8c531533dd3e 100644
> --- a/arch/powerpc/kernel/fadump.c
> +++ b/arch/powerpc/kernel/fadump.c
> @@ -289,10 +289,8 @@ static void __init fadump_show_config(void)
> if (!fw_dump.fadump_supported)
> return;
>
> - pr_debug("Fadump enabled : %s\n",
> - (fw_dump.fadump_enabled ? "yes" : "no"));
> - pr_debug("Dump Active : %s\n",
> - (fw_dump.dump_active ? "yes" : "no"));
> + pr_debug("Fadump enabled : %s\n", str_yes_no(fw_dump.fadump_enabled));
> + pr_debug("Dump Active : %s\n", str_yes_no(fw_dump.dump_active));
> pr_debug("Dump section sizes:\n");
> pr_debug(" CPU state data size: %lx\n", fw_dump.cpu_state_data_size);
> pr_debug(" HPTE region size : %lx\n", fw_dump.hpte_region_size);
> --
> 2.47.1