public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: ChengChaoChun <abc21531050@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/interrupt.h: fix struct irqaction comment order inconsistency
Date: Fri, 26 Jul 2024 18:33:34 +0200	[thread overview]
Message-ID: <87ikwsun8h.ffs@tglx> (raw)
In-Reply-To: <20240708160651.54239-1-abc21531050@gmail.com>

On Tue, Jul 09 2024 at 00:06, ChengChaoChun wrote:
>  /**
>   * struct irqaction - per interrupt action descriptor
> - * @handler:	interrupt handler function
> - * @name:	name of the device
> - * @dev_id:	cookie to identify the device
> - * @percpu_dev_id:	cookie to identify the device
> - * @next:	pointer to the next irqaction for shared interrupts
> - * @irq:	interrupt number
> - * @flags:	flags (see IRQF_* above)
> - * @thread_fn:	interrupt handler function for threaded interrupts
> - * @thread:	thread pointer for threaded interrupts
> - * @secondary:	pointer to secondary irqaction (force threading)
> - * @thread_flags:	flags related to @thread
> - * @thread_mask:	bitmask for keeping track of @thread activity
> - * @dir:	pointer to the proc/irq/NN/name entry
> + * @handler:    interrupt handler function

This changes tabs to spaces ....

> + * @dev_id:     cookie to identify the device
> + * @percpu_dev_id:      cookie to identify the device
> + * @next:       pointer to the next irqaction for shared interrupts
> + * @thread_fn:  interrupt handler function for threaded interrupts
> + * @thread:     thread pointer for threaded interrupts
> + * @secondary:  pointer to secondary irqaction (force threading)
> + * @irq:        interrupt number
> + * @flags:      flags (see IRQF_* above)
> + * @thread_flags:       flags related to @thread
> + * @thread_mask:        bitmask for keeping track of @thread activity

And while at it, please align all members in a tabular fashion.

Thanks,

        tglx

      reply	other threads:[~2024-07-26 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08 16:06 [PATCH] linux/interrupt.h: fix struct irqaction comment order inconsistency ChengChaoChun
2024-07-26 16:33 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ikwsun8h.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=abc21531050@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox