From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>
Cc: Yury Norov <yury.norov@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: Re: [PATCH v3 2/3] bits: Introduce fixed-type BIT
Date: Fri, 09 Feb 2024 10:01:58 +0200 [thread overview]
Message-ID: <87il2yaww9.fsf@intel.com> (raw)
In-Reply-To: <ilppncjskpt52bijaoxlwcklawjpw5cqrndtx2g5xnwpj6bhbm@kn5yjscaha5e>
On Thu, 08 Feb 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Thu, Feb 08, 2024 at 09:04:45PM +0100, Andi Shyti wrote:
>>Hi Lucas,
>>
>>looks good, just one idea...
>>
>>...
>>
>>> +#define BIT_U8(b) ((u8)(BIT_INPUT_CHECK(u8, b) + BIT(b)))
>>> +#define BIT_U16(b) ((u16)(BIT_INPUT_CHECK(u16, b) + BIT(b)))
>>> +#define BIT_U32(b) ((u32)(BIT_INPUT_CHECK(u32, b) + BIT(b)))
>>> +#define BIT_U64(b) ((u64)(BIT_INPUT_CHECK(u64, b) + BIT(b)))
>>
>>considering that BIT defines are always referred to unsigned
>>types, I would just call them
>>
>>#define BIT8
>>#define BIT16
>>#define BIT32
>>#define BIT64
>>
>>what do you think?
>
> it will clash with defines from other headers and not match the ones for
> GENMASK so I prefer it the other way.
Agreed.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-02-09 8:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 7:45 [PATCH v3 0/3] Fixed-type GENMASK/BIT Lucas De Marchi
2024-02-08 7:45 ` [PATCH v3 1/3] bits: introduce fixed-type genmasks Lucas De Marchi
2024-02-08 19:48 ` Andi Shyti
2024-02-09 14:04 ` Andy Shevchenko
2024-02-21 20:30 ` Dmitry Baryshkov
2024-02-21 20:37 ` Dmitry Baryshkov
2024-02-21 21:06 ` Andy Shevchenko
2024-02-21 21:07 ` Andy Shevchenko
2024-02-21 21:04 ` Andy Shevchenko
2024-02-21 21:59 ` Lucas De Marchi
2024-02-22 14:49 ` Yury Norov
2024-02-22 15:04 ` Andy Shevchenko
2024-02-22 21:31 ` Yury Norov
2024-02-28 23:39 ` Lucas De Marchi
2024-02-29 10:49 ` Andy Shevchenko
2024-02-29 18:21 ` Lucas De Marchi
2024-02-29 18:27 ` Andy Shevchenko
2024-03-01 4:06 ` Lucas De Marchi
2024-03-07 21:45 ` Lucas De Marchi
2024-02-08 7:45 ` [PATCH v3 2/3] bits: Introduce fixed-type BIT Lucas De Marchi
2024-02-08 20:04 ` Andi Shyti
2024-02-08 21:17 ` Lucas De Marchi
2024-02-09 8:01 ` Jani Nikula [this message]
2024-02-10 14:22 ` David Laight
2024-02-09 16:53 ` Yury Norov
2024-02-20 5:13 ` Lucas De Marchi
2024-02-22 14:51 ` Yury Norov
2024-02-22 16:35 ` Lucas De Marchi
2024-02-08 7:45 ` [PATCH v3 3/3] drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_* Lucas De Marchi
2024-02-08 8:49 ` Jani Nikula
2024-02-08 20:07 ` Andi Shyti
2024-02-08 21:21 ` Lucas De Marchi
2025-02-02 10:40 ` [PATCH v3 0/3] Fixed-type GENMASK/BIT Vincent Mailhol
2025-02-03 14:29 ` Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il2yaww9.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox