* Re: [PATCH] ALSA: hda: cs35l41: mark cs35l41_verify_id() static
[not found] <20231027152515.482411-1-arnd@kernel.org>
@ 2023-10-29 7:29 ` Takashi Iwai
0 siblings, 0 replies; only message in thread
From: Takashi Iwai @ 2023-10-29 7:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: James Schulman, David Rhodes, Richard Fitzgerald, Jaroslav Kysela,
Takashi Iwai, Stefan Binding, Arnd Bergmann, Mark Brown,
Cristian Ciocaltea, alsa-devel, patches, linux-sound,
linux-kernel
On Fri, 27 Oct 2023 17:25:09 +0200,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly introduced function is global but only called in this one
> file and has no extern prototype, so it should probably be static:
>
> sound/pci/hda/cs35l41_hda.c:733:5: error: no previous prototype for 'cs35l41_verify_id' [-Werror=missing-prototypes]
> 733 | int cs35l41_verify_id(struct cs35l41_hda *cs35l41, unsigned int *regid, unsigned int *reg_revid)
>
> Fixes: 881b7bce0c25 ("ALSA: hda: cs35l41: Run boot process during resume callbacks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] only message in thread