From: Luis Henriques <lhenriques@suse.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2] fs: simplify misleading code to remove ambiguity regarding ihold()/iput()
Date: Fri, 29 Sep 2023 10:24:54 +0100 [thread overview]
Message-ID: <87il7tz5zt.fsf@suse.de> (raw)
In-Reply-To: <20230928-zecken-werkvertrag-59ae5e5044de@brauner> (Christian Brauner's message of "Thu, 28 Sep 2023 18:21:58 +0200")
Hi Christian,
Christian Brauner <brauner@kernel.org> writes:
> On Thu, 28 Sep 2023 16:23:41 +0100, Luís Henriques wrote:
>> Because 'inode' is being initialised before checking if 'dentry' is negative
>> it looks like an extra iput() on 'inode' may happen since the ihold() is
>> done only if the dentry is *not* negative. In reality this doesn't happen
>> because d_is_negative() is never true if ->d_inode is NULL. This patch only
>> makes the code easier to understand, as I was initially mislead by it.
>>
>>
>> [...]
>
> Applied to the vfs.misc branch of the vfs/vfs.git tree.
> Patches in the vfs.misc branch should appear in linux-next soon.
>
> Please report any outstanding bugs that were missed during review in a
> new review to the original patch series allowing us to drop it.
>
> It's encouraged to provide Acked-bys and Reviewed-bys even though the
> patch has now been applied. If possible patch trailers will be updated.
>
> Note that commit hashes shown below are subject to change due to rebase,
> trailer updates or similar. If in doubt, please check the listed branch.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.misc
>
> [1/1] fs: simplify misleading code to remove ambiguity regarding ihold()/iput()
> https://git.kernel.org/vfs/vfs/c/5c29bcfaa4cf
Could you please double-check this was indeed applied? I can't see it
anywhere. Maybe I'm looking at the wrong place, but since your scripts
seem to have messed-up my email address, something else may have went
wrong.
Cheers,
--
Luís
next prev parent reply other threads:[~2023-09-29 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 15:23 [PATCH v2] fs: simplify misleading code to remove ambiguity regarding ihold()/iput() Luís Henriques
2023-09-28 16:21 ` Christian Brauner
2023-09-29 9:24 ` Luis Henriques [this message]
2023-09-29 9:28 ` Christian Brauner
2023-09-29 9:46 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il7tz5zt.fsf@suse.de \
--to=lhenriques@suse.de \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox