From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Maarten Lankhorst <dev@lankhorst.se>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v3 8/9] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe
Date: Fri, 18 Aug 2023 12:39:14 +0200 [thread overview]
Message-ID: <87il9ck52l.wl-tiwai@suse.de> (raw)
In-Reply-To: <e88d139f-e62b-1654-0d35-a46c698298c6@lankhorst.se>
On Mon, 14 Aug 2023 16:26:01 +0200,
Maarten Lankhorst wrote:
>
> Ping on this?
Pierre? Does one of your recent patch sets achieves the suggested
thing? Or do we need another rewrite/respin of this series?
Currently it's blocking the merge for 6.6.
Takashi
> On 2023-08-12 10:17, Takashi Iwai wrote:
> > On Mon, 07 Aug 2023 16:26:53 +0200,
> > Pierre-Louis Bossart wrote:
> >>
> >>
> >>
> >> On 8/7/23 04:00, Maarten Lankhorst wrote:
> >>> Now that we can use -EPROBE_DEFER, it's no longer required to spin off
> >>> the snd_hdac_i915_init into a workqueue.
> >>>
> >>> Use the -EPROBE_DEFER mechanism instead, which must be returned in the
> >>> probe function.
> >>
> >> I don't think this patch is aligned with the previous discussions. What
> >> we agreed on is that snd_hdac_i915_init() would be called from and not
> >> from the workqueue.
> >>
> >> But this patch also moves all codec initialization out of the workqueue.
> >>
> >> I think we need two callbacks for device-specific initilization, one
> >> that is called from the probe function and one from the workqueue,
> >> otherwise we'll have a structure that differs from the snd-hda-intel -
> >> which would be rather silly in terms of support/debug.
> >>
> >> I realize there's quite a bit of surgery involved, and most likely the
> >> SOF folks should provide this patch for you to build on.
> >
> > So this patch looks like the only significant concern in the whole
> > patch set. Can we reach to some agreement for merging to 6.6 in time?
> >
> >
> > thanks,
> >
> > Takashi
>
next prev parent reply other threads:[~2023-08-18 10:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 9:00 [PATCH v3 0/9] sound: Use -EPROBE_DEFER instead of i915 module loading Maarten Lankhorst
2023-08-07 9:00 ` [PATCH v3 1/9] ALSA: hda/intel: Fix error handling in azx_probe() Maarten Lankhorst
2023-08-07 9:00 ` [PATCH v3 2/9] ALSA: hda/i915: Allow override of gpu binding Maarten Lankhorst
2023-08-07 14:06 ` Pierre-Louis Bossart
2023-08-07 9:00 ` [PATCH v3 3/9] ALSA: hda/i915: Add an allow_modprobe argument to snd_hdac_i915_init Maarten Lankhorst
2023-08-07 14:08 ` Pierre-Louis Bossart
2023-08-12 8:21 ` Takashi Iwai
2023-08-12 14:43 ` Maarten Lankhorst
2023-08-07 9:00 ` [PATCH v3 4/9] ALSA: hda/i915: Allow xe as match for i915_component_master_match Maarten Lankhorst
2023-08-07 14:11 ` Pierre-Louis Bossart
2023-08-07 9:00 ` [PATCH v3 5/9] ASoC: Intel: avs: Move snd_hdac_i915_init to before probe_work Maarten Lankhorst
2023-08-07 14:13 ` Pierre-Louis Bossart
2023-08-07 9:00 ` [PATCH v3 6/9] ASoC: Intel: Skylake: " Maarten Lankhorst
2023-08-07 9:00 ` [PATCH v3 7/9] ALSA: hda/intel: " Maarten Lankhorst
2023-08-07 14:17 ` Pierre-Louis Bossart
2023-08-07 9:00 ` [PATCH v3 8/9] ASoC: SOF: Intel: Move binding to display driver outside of deferred probe Maarten Lankhorst
2023-08-07 14:26 ` Pierre-Louis Bossart
2023-08-12 8:17 ` Takashi Iwai
2023-08-14 14:26 ` Maarten Lankhorst
2023-08-18 10:39 ` Takashi Iwai [this message]
2023-08-18 12:24 ` Kai Vehmanen
2023-08-18 12:46 ` Takashi Iwai
2023-08-07 9:00 ` [PATCH v3 9/9] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init Maarten Lankhorst
2023-08-07 14:28 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il9ck52l.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=dev@lankhorst.se \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox