From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BFFC001E0 for ; Wed, 2 Aug 2023 15:55:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235401AbjHBPz3 (ORCPT ); Wed, 2 Aug 2023 11:55:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235387AbjHBPzK (ORCPT ); Wed, 2 Aug 2023 11:55:10 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 927003C14 for ; Wed, 2 Aug 2023 08:54:30 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E3C9F1F37C; Wed, 2 Aug 2023 15:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1690991668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DpvkF7h/6CHY1yRubkDyJc0q7vYwpDpt2jComXffOdQ=; b=xp7T6BbWPDzODxs+8z1dlCsYH2dEpvz+dKStQDFNSv/XuDNKaBwWCS+Y3pxaCDSJ3xHZze QI9FXGwZoOEU3RYP2DT6U4DJthtkEcjGOPXCvadjOuEiiiA4k//yT5X8XvtlN/623HSXnJ W3hg/2dZq4jgC2dPFY12uzLEG7CqIs0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1690991668; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DpvkF7h/6CHY1yRubkDyJc0q7vYwpDpt2jComXffOdQ=; b=i98CGzjHOQKbfazm2d3tzxMuoDpRAzJVLI79wUtG0ZXxmsMKXUYqOLTCAs05BXdhUIrhx3 zFw03QK0cW8V39BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B064A13909; Wed, 2 Aug 2023 15:54:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cDJCKjR8ymROOwAAMHmgww (envelope-from ); Wed, 02 Aug 2023 15:54:28 +0000 Date: Wed, 02 Aug 2023 17:54:28 +0200 Message-ID: <87il9xcudn.wl-tiwai@suse.de> From: Takashi Iwai To: Matthew Anderson Cc: tiwai@suse.com, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ALSA: hda/realtek: Add headphone quirk for Aya Neo 2 In-Reply-To: <20230802153730.39273-3-ruinairas1992@gmail.com> References: <20230802153730.39273-1-ruinairas1992@gmail.com> <20230802153730.39273-3-ruinairas1992@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Aug 2023 17:37:30 +0200, Matthew Anderson wrote: > > This fixes the headphones on the Aya Neo 2 handheld. > Signed-off-by: Matthew Anderson > --- > sound/pci/hda/patch_realtek.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 33f9beec8179..5d31cbe5d40b 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -7030,6 +7030,7 @@ enum { > ALC269_FIXUP_DELL3_MIC_NO_PRESENCE, > ALC269_FIXUP_DELL4_MIC_NO_PRESENCE, > ALC269_FIXUP_DELL4_MIC_NO_PRESENCE_QUIET, > + ALC269_FIXUP_HEADSET_AYA_2, > ALC269_FIXUP_HEADSET_AYA_GEEK, > ALC269_FIXUP_HEADSET_MODE, > ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC, > @@ -8455,6 +8456,10 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE > }, > + [ALC269_FIXUP_HEADSET_AYA_2] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc269_fixup_headphone_volume, > + }, > [ALC269_FIXUP_HEADSET_AYA_GEEK] = { > .type = HDA_FIXUP_FUNC, > .v.func = alc269_fixup_headphone_volume, > @@ -9953,6 +9958,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1d72, 0x1901, "RedmiBook 14", ALC256_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1d72, 0x1945, "Redmi G", ALC256_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1d72, 0x1947, "RedmiBook Air", ALC255_FIXUP_XIAOMI_HEADSET_MIC), > + SND_PCI_QUIRK(0x1f66, 0x0101, "AYANEO 2", ALC269_FIXUP_HEADSET_AYA_2), > SND_PCI_QUIRK(0x1f66, 0x0101, "GEEK", ALC269_FIXUP_HEADSET_AYA_GEEK), > SND_PCI_QUIRK(0x8086, 0x2074, "Intel NUC 8", ALC233_FIXUP_INTEL_NUC8_DMIC), > SND_PCI_QUIRK(0x8086, 0x2080, "Intel NUC 8 Rugged", ALC256_FIXUP_INTEL_NUC8_RUGGED), Hmm, both devices have the very same SSID (1f66:0101)? Then it's superfluous. And, if you have two devices that require the same quirk but with different SSIDs, both can use the same ALC269_FIXUP_HEADSET_AYA_GEEK, instead of defining two. thanks, Takashi