From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC993C4321E for ; Fri, 2 Dec 2022 13:15:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233381AbiLBNPT (ORCPT ); Fri, 2 Dec 2022 08:15:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232011AbiLBNPR (ORCPT ); Fri, 2 Dec 2022 08:15:17 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B45C2D34; Fri, 2 Dec 2022 05:15:16 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8026121B98; Fri, 2 Dec 2022 13:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669986915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ziDC4wku+9nZYy20pOYDbXvY6zGCI5yr6NmjzJA9rks=; b=bBJTOHNxINOaPLEQSsBGm6AQOJZyLuQBIyAT81NugBzo70N/7g3d7so0VuUGMnuFpElFoR qA2Jf7GnRu+kXBmgtETBirnrqQjNHVngI5UJClOb5Fb1PvemjgHG60pjEGt+NzsiKiIYQF w8pYL9OW+G1QlbLdSaMla/inT8rmZFo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669986915; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ziDC4wku+9nZYy20pOYDbXvY6zGCI5yr6NmjzJA9rks=; b=mAu6xNLHYwcLYVwbWUg/9bBzYlUOdO60N/rEJuQlCY7Mu5iFfKCHTt5a5SSRkOhFMxIQmE CAzqpVk3blgdkQCA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 51ADB133DE; Fri, 2 Dec 2022 13:15:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 1OtNE2P6iWPURQAAGKfGzw (envelope-from ); Fri, 02 Dec 2022 13:15:15 +0000 Date: Fri, 02 Dec 2022 14:15:14 +0100 Message-ID: <87iliuoskd.wl-tiwai@suse.de> From: Takashi Iwai To: Dicheng Wang Cc: perex@perex.cz, tiwai@suse.com, sdoregor@sdore.me, john-linux@pelago.org.uk, hahnjo@hahnjo.de, wangdicheng@kylinos.cn, connerknoxpublic@gmail.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH -next] The USB audio driver does not contain the VID and PID of this sound card, so the driver is not loaded. In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 02 Dec 2022 09:29:08 +0100, Dicheng Wang wrote: > > From: wangdicheng > > Add relevant information to the quirks-table.h file. > The test passes and the sound source file plays normally. > > Cc: stable@vger.kernel.org > Signed-off-by: wangdicheng The code change itself looks good, but could you fix the patch subject line? It should have the proper prefix (in this case something like "ALSA: usb-audio: Blah blah..."), and the text is unnecessarily long. Please make it concise. Also, could you give the lsusb -v output of the corresponding device? Just to make sure. If possible, it'd be better to use the existing macro like USB_DEVICE_VENDOR_SPEC() or USB_AUDIO_DEVICE() instead. thanks, Takashi > --- > sound/usb/quirks-table.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h > index 874fcf245747..1fb183895da0 100644 > --- a/sound/usb/quirks-table.h > +++ b/sound/usb/quirks-table.h > @@ -2802,6 +2802,13 @@ YAMAHA_DEVICE(0x7010, "UB99"), > .idProduct = 0x1020, > }, > > +/* Ktmicro Usb_audio device */ > +{ > + .match_flags = USB_DEVICE_ID_MATCH_DEVICE, > + .idVendor = 0x31b2, > + .idProduct = 0x0011, > +}, > + > /* QinHeng devices */ > { > USB_DEVICE(0x1a86, 0x752d), > -- > 2.25.1 >