From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2B8CC433F5 for ; Tue, 4 Oct 2022 17:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229935AbiJDRjN (ORCPT ); Tue, 4 Oct 2022 13:39:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbiJDRid (ORCPT ); Tue, 4 Oct 2022 13:38:33 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FDB89FE6 for ; Tue, 4 Oct 2022 10:38:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664905112; x=1696441112; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=q6EpAzeaREMD6X3gyCf0BKwJue0LMO9WqhXpb/0sZyA=; b=FpnFHVc7o4kirI/MeYWBLIoSqCmkkh+HD0ddzYx8DTfPOKzHIvhLtR0y ZxwPwIhG1kIovvNeeZyJWG5UFDNhVMZsNkXoGcLUDwa7/dyttK3w83PzJ rWsVoFVep+tZIUv4zVWdu5Ypw2qyP0snycGuLQyc1pMcQg+nZdFxpCLmP C6Y+l7VEmxJx1rgsEicVgvuwEZ/BN1o9Z3DSYkQ0eV6jePcU9VqBFpG8R Gqwk2FIFWbZN+qw2CKqJqqs9mO6Kgz5pTa+ma3rGGE1/FGinRbkrDyrYg 2H7vZbNzao//qsIqMRuRj5ZriPswv9gF80BpX8iiw52pfB1taJRmU1yoJ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="301698183" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="301698183" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 10:38:31 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10490"; a="657211821" X-IronPort-AV: E=Sophos;i="5.95,158,1661842800"; d="scan'208";a="657211821" Received: from pvarla-mobl4.gar.corp.intel.com (HELO localhost) ([10.252.39.104]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2022 10:38:27 -0700 From: Jani Nikula To: Pablo Ceballos , David Airlie , Daniel Vetter Cc: Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Ville =?utf-8?B?U3lyasOkbMOk?= , Thomas Zimmermann , Javier Martinez Canillas , Sam Ravnborg , Pablo Ceballos , Maxime Ripard , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/i915/display/lspcon: Increase LSPCON mode settle timeout In-Reply-To: <20220915004601.320198-1-pceballos@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220915004601.320198-1-pceballos@google.com> Date: Tue, 04 Oct 2022 20:38:24 +0300 Message-ID: <87ilkzsd4f.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Sep 2022, Pablo Ceballos wrote: > On some devices the Parade PS175 takes more than 400ms to settle in PCON > mode. Got any bug report with more info, or any other details to back this up? This is kind of thin. What's the 800 ms based on? BR, Jani. > > Signed-off-by: Pablo Ceballos > --- > drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c > index 15d59de8810e..b4cbade13ee5 100644 > --- a/drivers/gpu/drm/i915/display/intel_lspcon.c > +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c > @@ -166,7 +166,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon, > drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n", > lspcon_mode_name(mode)); > > - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400); > + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800); > if (current_mode != mode) > drm_err(&i915->drm, "LSPCON mode hasn't settled\n"); -- Jani Nikula, Intel Open Source Graphics Center