From: Takashi Iwai <tiwai@suse.de>
To: Brent Lu <brent.lu@intel.com>
Cc: alsa-devel@alsa-project.org, "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Mohan Kumar" <mkumard@nvidia.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Yong Zhi" <yong.zhi@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/hdmi: run eld notify in delay work
Date: Tue, 27 Sep 2022 16:11:27 +0200 [thread overview]
Message-ID: <87ill8gb5c.wl-tiwai@suse.de> (raw)
In-Reply-To: <20220927135807.4097052-1-brent.lu@intel.com>
On Tue, 27 Sep 2022 15:58:07 +0200,
Brent Lu wrote:
>
> During resolution change, display driver would disable HDMI audio then
> enable it in a short time. There is possibility that eld notify for
> HDMI audio enable is called when previous runtime suspend is still
> running. In this case, the elf nofity just returns and not updating the
> status of corresponding HDMI pin/port. Here we move the eld nofity to
> a delay work so we don't lose it.
>
> Signed-off-by: Brent Lu <brent.lu@intel.com>
We have already a dedicated per-pin work for the delayed ELD check.
Can we reuse it instead of inventing yet another work?
More work needs more cares, and better to avoid unless really needed
(e.g. you forgot cleanup at suspend/removal in this patch).
thanks,
Takashi
next prev parent reply other threads:[~2022-09-27 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 13:58 [PATCH] ALSA: hda/hdmi: run eld notify in delay work Brent Lu
2022-09-27 14:11 ` Takashi Iwai [this message]
2022-09-28 2:06 ` Lu, Brent
2022-09-28 7:14 ` Takashi Iwai
2022-09-28 8:09 ` Takashi Iwai
2022-09-28 8:37 ` Takashi Iwai
2022-10-05 8:14 ` Lu, Brent
2022-10-05 9:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ill8gb5c.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=ville.syrjala@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox