Re: [PATCH 12/12] drm/udl: Sync pending URBs at the end of suspend

[Takashi Iwai <tiwai@suse.de>]

On Mon, 05 Sep 2022 10:44:25 +0200,
Thomas Zimmermann wrote:
> 
> Hi
> 
> Am 16.08.22 um 17:36 schrieb Takashi Iwai:
> > It's better to perform the sync at the very last of the suspend
> > instead of the pipe-disable function, so that we can catch all pending
> > URBs (if any).
> > 
> > While we're at it, drop the error code from udl_sync_pending_urb()
> > since we basically ignore it; instead, give a clear error message
> > indicating a problem.
> 
> But if we fail, shouldn't we report that error to the caller of the
> suspend function?

It's an open question.  We may fail the suspend, but OTOH, the sync
error is likely nothing we can recover from at any time later, either;
that is, even if we return an error and abort the suspend, it wouldn't
help so much from the practical POV.  So for now -- and just for this
URL device handling -- I'm inclined to continue suspending.  But if
anyone has more strong argument against it, I'm all ears.


thanks,

Takashi