Re: [PATCH 03/12] timer: Protect lockdep functions with #ifdef

Steven Rostedt
2022-02-08T22:34:07Z

On Tue, 8 Feb 2022 12:29:32 -0800
Namhyung Kim <namhyung@kernel.org> wrote:

> Hi Steve,
>
> On Tue, Feb 8, 2022 at 11:36 AM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Tue, 8 Feb 2022 10:41:59 -0800
> > Namhyung Kim <namhyung@kernel.org> wrote:
> >
> > > With upcoming lock tracepoints config, it'd define some of lockdep
> > > functions without enabling CONFIG_LOCKDEP actually. The existing code
> > > assumes those functions will be removed by the preprocessor but it's
> > > not the case anymore. Let's protect the code with #ifdef's explicitly.
> >
> > I wonder if it would be cleaner to have another macro name for these
> > locations to keep out the ugly #ifdef in the code.
> >
> > lockdep_init_map_raw() ?
>
> Yeah, I like that.. Then I also need to add the _raw variants
> for acquire, release and so on. Is that ok?
>

Yeah, most definitely.

Thanks,

-- Steve