From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [patch 5/5] sched: Move mmdrop to RCU on RT
Date: Wed, 29 Sep 2021 15:05:41 +0200 [thread overview]
Message-ID: <87ilyj8rbu.ffs@tglx> (raw)
In-Reply-To: <YVRV2jhVIbGxd+JB@hirez.programming.kicks-ass.net>
On Wed, Sep 29 2021 at 14:02, Peter Zijlstra wrote:
> On Tue, Sep 28, 2021 at 02:24:32PM +0200, Thomas Gleixner wrote:
>> +#ifdef CONFIG_PREEMPT_RT
>> +/*
>> + * RCU callback for delayed mm drop. Not strictly RCU, but call_rcu() is
>> + * by far the least expensive way to do that.
>> + */
>> +void __mmdrop_delayed(struct rcu_head *rhp)
>> +{
>> + struct mm_struct *mm = container_of(rhp, struct mm_struct, delayed_drop);
>> +
>> + __mmdrop(mm);
>> +}
>> +#endif
>
> Would you mind terribly if I fold this into mm.h as a static inline ?
>
> The only risk that carries is that if mmdrop_sched() is called from
> multiple translation units (it is not) we get multiple instances of this
> function, but possibly even !LTO linkers can fix that for us.
No preference here.
next prev parent reply other threads:[~2021-09-29 13:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 12:24 [patch 0/5] sched: Miscellaneous RT related tweaks Thomas Gleixner
2021-09-28 12:24 ` [patch 1/5] sched: Limit the number of task migrations per batch on RT Thomas Gleixner
2021-10-01 15:05 ` [tip: sched/core] " tip-bot2 for Thomas Gleixner
2021-10-05 14:11 ` tip-bot2 for Thomas Gleixner
2021-09-28 12:24 ` [patch 2/5] sched: Disable TTWU_QUEUE " Thomas Gleixner
2021-10-01 15:05 ` [tip: sched/core] " tip-bot2 for Thomas Gleixner
2021-10-05 14:11 ` tip-bot2 for Thomas Gleixner
2021-09-28 12:24 ` [patch 3/5] sched: Move kprobes cleanup out of finish_task_switch() Thomas Gleixner
2021-10-01 15:05 ` [tip: sched/core] " tip-bot2 for Thomas Gleixner
2021-10-05 14:11 ` tip-bot2 for Thomas Gleixner
2021-09-28 12:24 ` [patch 4/5] sched: Delay task stack freeing on RT Thomas Gleixner
2021-09-29 11:54 ` Peter Zijlstra
2021-10-01 16:12 ` Andy Lutomirski
2021-10-01 17:24 ` Thomas Gleixner
2021-10-01 18:48 ` Andy Lutomirski
2021-10-01 19:02 ` Andy Lutomirski
2021-10-01 20:54 ` Thomas Gleixner
2021-09-28 12:24 ` [patch 5/5] sched: Move mmdrop to RCU " Thomas Gleixner
2021-09-29 12:02 ` Peter Zijlstra
2021-09-29 13:05 ` Thomas Gleixner [this message]
2021-10-01 15:05 ` [tip: sched/core] " tip-bot2 for Thomas Gleixner
2021-10-05 14:11 ` tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilyj8rbu.ffs@tglx \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox