From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20EACC433EF for ; Wed, 8 Sep 2021 13:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 080CC6109F for ; Wed, 8 Sep 2021 13:42:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349450AbhIHNn1 (ORCPT ); Wed, 8 Sep 2021 09:43:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28791 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348290AbhIHNnZ (ORCPT ); Wed, 8 Sep 2021 09:43:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631108537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fuGy5OOl1BDAOfZOmjSgNM6SnXA/iPvMi1tfPhWc/iI=; b=SNXc+W2auWzTNKp/VEk8vXrFxuov+gBoMZ/0WZF9O0ZGZcPGaRbE/vBX6tzmcchC5rNXX7 ygRi0D5HgyOOd4SYvYr9XI9x7SI5xJ6eazW2zP0y+Lg0y2V/HLGL/ZkVTpu10cBJprCTgy B6ottX1q2lXvXCY+RYHZslQ256rqzGc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-u-hWoZL0M7ygC9r-CRr07g-1; Wed, 08 Sep 2021 09:42:16 -0400 X-MC-Unique: u-hWoZL0M7ygC9r-CRr07g-1 Received: by mail-wm1-f70.google.com with SMTP id z18-20020a1c7e120000b02902e69f6fa2e0so941613wmc.9 for ; Wed, 08 Sep 2021 06:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=fuGy5OOl1BDAOfZOmjSgNM6SnXA/iPvMi1tfPhWc/iI=; b=HJCy+dHMkyGsz0ZxgL0i2t2kXgKkrEank3u/xnOO9VuPHDdm70l43boZo2lqwqy3Su 1f2pfbgtHSuM3aWpF2fj1v0hH6NE714hT6BcZgVHKvL6nUAIx4+vIzw1BthzdtJv21Pi wFVI7Oflg/QYFPSOCAww43fJPFjw4iaD1z+vOgGdfHbjldYrg/CF5aReNSRO9Qdv6/Mb sLoKnVHZIp6+/S8HeClI37RvcsLtx2MgMpJ6sNg0tHh0jHxtsGl1/8/7wxYNKl0fy5o/ UHE+lf42BkZD5oYlC5Tcf3jmpyQ4+7lGd604qhSw5ptShvV8UvR2NRVkvqjYL4KPiyzN CYWA== X-Gm-Message-State: AOAM531uQEE/mUQfqJcKJ5eom69Ff8GFUcCc4zj3bUJH2FceSb33UYrN 3sZ6cI1gOiMMj3BZ1RTjiro77vmajRDhpMRNIjyCZDhYlCpZ3J/b+4QDukyXYUKMYIywEWZmBrt WvcjVR3z2V2h+aLW+12nSwcNi X-Received: by 2002:a05:600c:3ba3:: with SMTP id n35mr3629818wms.166.1631108535278; Wed, 08 Sep 2021 06:42:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvHcnnS7MP3mZPfZE2jXaaeg34pU4rY4GeR9ZOGIHALmoLe6qfMvd5sMR9ubN8iZrFnb7hyA== X-Received: by 2002:a05:600c:3ba3:: with SMTP id n35mr3629794wms.166.1631108534994; Wed, 08 Sep 2021 06:42:14 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id r25sm2624372wrc.26.2021.09.08.06.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 06:42:14 -0700 (PDT) From: Vitaly Kuznetsov To: Yu Zhang Cc: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org Subject: Re: [PATCH] KVM: nVMX: fix comments of handle_vmon() In-Reply-To: <20210908130145.3uwmywgjaahyb6iw@linux.intel.com> References: <20210908171731.18885-1-yu.c.zhang@linux.intel.com> <87lf474ci8.fsf@vitty.brq.redhat.com> <20210908130145.3uwmywgjaahyb6iw@linux.intel.com> Date: Wed, 08 Sep 2021 15:42:13 +0200 Message-ID: <87ilzb4216.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yu Zhang writes: > On Wed, Sep 08, 2021 at 11:55:59AM +0200, Vitaly Kuznetsov wrote: >> Indeed, >> >> Reviewed-by: Vitaly Kuznetsov >> >> On a slightly related note: we don't seem to reset >> 'vmx->nested.vmxon_ptr' upon VMXOFF emulation; this is not a problem per >> se as we never access it when !vmx->nested.vmxon but I'd still suggest >> we do something like >> >> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c >> index bc6327950657..8beb41d02d21 100644 >> --- a/arch/x86/kvm/vmx/nested.c >> +++ b/arch/x86/kvm/vmx/nested.c >> @@ -290,6 +290,7 @@ static void free_nested(struct kvm_vcpu *vcpu) >> >> vmx->nested.vmxon = false; >> vmx->nested.smm.vmxon = false; >> + vmx->nested.vmxon_ptr = -1ull; >> free_vpid(vmx->nested.vpid02); >> vmx->nested.posted_intr_nv = -1; >> vmx->nested.current_vmptr = -1ull; >> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c >> index d7c5257eb5c0..2214e6bd4713 100644 >> --- a/arch/x86/kvm/vmx/vmx.c >> +++ b/arch/x86/kvm/vmx/vmx.c >> @@ -6884,6 +6884,7 @@ static int vmx_create_vcpu(struct kvm_vcpu *vcpu) >> >> vcpu_setup_sgx_lepubkeyhash(vcpu); >> >> + vmx->nested.vmxon_ptr = -1ull; >> vmx->nested.posted_intr_nv = -1; >> vmx->nested.current_vmptr = -1ull; >> vmx->nested.hv_evmcs_vmptr = EVMPTR_INVALID; >> >> to avoid issues in the future. >> > Thanks, Vitaly. And above suggestion sounds reasonable to me. :) > > I can add this in V2 later, if no one objects. > Sure, this is rather a separate patch. Thanks! -- Vitaly