From: Michael Ellerman <mpe@ellerman.id.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Xiongwei Song <sxwjean@me.com>,
benh@kernel.crashing.org, paulus@samba.org, oleg@redhat.com,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
msuchanek@suse.de, aneesh.kumar@linux.ibm.com,
ravi.bangoria@linux.ibm.com, mikey@neuling.org,
haren@linux.ibm.com, alistair@popple.id.au, jniethe5@gmail.com,
peterz@infradead.org, leobras.c@gmail.com,
akpm@linux-foundation.org, rppt@kernel.org, peterx@redhat.com,
atrajeev@linux.vnet.ibm.com, maddy@linux.ibm.com,
kjain@linux.ibm.com, kan.liang@linux.intel.com, aik@ozlabs.ru,
pmladek@suse.com, john.ogness@linutronix.de,
Xiongwei Song <sxwjean@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/traps: Enhance readability for trap types
Date: Thu, 01 Apr 2021 13:39:28 +1100 [thread overview]
Message-ID: <87im5620f3.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20210331212550.GD13863@gate.crashing.org>
Segher Boessenkool <segher@kernel.crashing.org> writes:
> On Wed, Mar 31, 2021 at 08:58:17PM +1100, Michael Ellerman wrote:
>> So perhaps:
>>
>> EXC_SYSTEM_RESET
>> EXC_MACHINE_CHECK
>> EXC_DATA_STORAGE
>> EXC_DATA_SEGMENT
>> EXC_INST_STORAGE
>> EXC_INST_SEGMENT
>> EXC_EXTERNAL_INTERRUPT
>> EXC_ALIGNMENT
>> EXC_PROGRAM_CHECK
>> EXC_FP_UNAVAILABLE
>> EXC_DECREMENTER
>> EXC_HV_DECREMENTER
>> EXC_SYSTEM_CALL
>> EXC_HV_DATA_STORAGE
>> EXC_PERF_MONITOR
>
> These are interrupt (vectors), not exceptions. It doesn't matter all
> that much, but confusing things more isn't useful either! There can be
> multiple exceptions that all can trigger the same interrupt.
Yeah I know, but I think that ship has already sailed as far as the
naming we have in the kernel.
We have over 250 uses of "exc", and several files called "exception"
something.
Using "interrupt" can also be confusing because Linux uses that to mean
"external interrupt".
But I dunno, maybe INT or VEC is clearer? .. or TRAP :)
cheers
next prev parent reply other threads:[~2021-04-01 2:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 15:04 [PATCH v2] powerpc/traps: Enhance readability for trap types Xiongwei Song
2021-03-31 9:58 ` Michael Ellerman
2021-03-31 21:25 ` Segher Boessenkool
2021-04-01 2:39 ` Michael Ellerman [this message]
2021-04-01 8:01 ` Nicholas Piggin
2021-04-01 16:16 ` Segher Boessenkool
2021-04-05 12:10 ` Xiongwei Song
[not found] ` <CAEVVKH8XDiEGHjXj6sJAHynhwqKWpNqj_Ws03AqwNjR8OmHf5w@mail.gmail.com>
2021-04-01 16:11 ` Segher Boessenkool
2021-04-02 0:36 ` Nicholas Piggin
2021-04-05 12:18 ` Xiongwei Song
2021-04-05 12:03 ` Xiongwei Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im5620f3.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=alistair@popple.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=haren@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=leobras.c@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mikey@neuling.org \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rppt@kernel.org \
--cc=segher@kernel.crashing.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox