Re: [PATCH v4 4/7] genirq: introduce irq_suspend_parent() and irq_resume_parent()

Doug Anderson
2020-08-11T20:11:14Z

Hi,

On Mon, Aug 10, 2020 at 4:21 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>
> From: Douglas Anderson <dianders@chromium.org>
>
> This goes with the new irq_suspend_one() and irq_resume_one()
> callbacks and allow us to easily pass things up to our parent.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
> include/linux/irq.h | 2 ++
> kernel/irq/chip.c | 28 ++++++++++++++++++++++++++++
> 2 files changed, 30 insertions(+)

Thanks for posting my patch. Small nit here is that when I saw the
patches listed together I realized that I forgot to capitalize
"introduce" in ${SUBJECT}. The two patches right next to each other
that both start with "introduce" where one has a capital and one
doesn't look weird. Hopefully you can fix in the next version?

Thanks!

-Doug